Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2116443002: Restricting output device authorization timeout to Windows only. (Closed)

Created:
4 years, 5 months ago by o1ka
Modified:
4 years, 5 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org, DaleCurtis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restricting output device authorization timeout to Windows only. Previous CL on authorization timeout decrease is being reverted https://codereview.chromium.org/2106373002/, this one should be landed instead. The reason is we hit authorization timeout on platforms other than Windows (https://uma.googleplex.com/p/chrome/timeline_v2?sid=74e6fc3b3d0ef041f64f37272402ebb1), but the goal was to address windows driver hangs only. BUG=615589 Committed: https://crrev.com/b9debcdd14086d59327dcb0cfd2044b41c998ae8 Cr-Commit-Position: refs/heads/master@{#403164}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix #

Patch Set 3 : rebasing to the revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M content/renderer/media/audio_device_factory.cc View 1 2 2 chunks +10 lines, -1 line 0 comments Download
M media/audio/audio_output_device.cc View 1 1 chunk +11 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Guido Urdaneta
lgtm https://codereview.chromium.org/2116443002/diff/1/content/renderer/media/audio_device_factory.cc File content/renderer/media/audio_device_factory.cc (right): https://codereview.chromium.org/2116443002/diff/1/content/renderer/media/audio_device_factory.cc#newcode28 content/renderer/media/audio_device_factory.cc:28: const int64_t kMaxAuthorizationTimeoutMs = 900; Add a comment ...
4 years, 5 months ago (2016-06-30 09:11:02 UTC) #2
o1ka
tommi@ PTAL
4 years, 5 months ago (2016-06-30 11:04:28 UTC) #7
tommi (sloooow) - chröme
lgtm
4 years, 5 months ago (2016-06-30 11:13:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116443002/80001
4 years, 5 months ago (2016-06-30 12:03:20 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 5 months ago (2016-06-30 13:29:22 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 13:30:54 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b9debcdd14086d59327dcb0cfd2044b41c998ae8
Cr-Commit-Position: refs/heads/master@{#403164}

Powered by Google App Engine
This is Rietveld 408576698