Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 21164002: Add tools\win\sizeviewer to dump partition view of binary size (Closed)

Created:
7 years, 4 months ago by scottmg
Modified:
7 years, 4 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Visibility:
Public.

Description

Add tools\win\sizeviewer to dump partition view of binary size chrome.dll (and optionally chrome_child.dll) must already be built and must be built with symbols. Script does not take any arguments: python tools\win\sizeviewer\sizeviewer.py And generates html files parallel to the DLLs. R=jamesr@chromium.org BUG=237249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214231

Patch Set 1 #

Patch Set 2 : +x on code_tally.exe #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, --1 lines) Patch
A tools/win/sizeviewer/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
A tools/win/sizeviewer/code_tally.exe View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/win/sizeviewer/sizeviewer.py View 1 chunk +95 lines, -0 lines 0 comments Download
A tools/win/sizeviewer/template.html View 1 chunk +199 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
7 years, 4 months ago (2013-07-29 21:45:46 UTC) #1
jamesr
lgtm, but make sure the .exe has the right mode bits. Looking at that raw ...
7 years, 4 months ago (2013-07-29 21:48:39 UTC) #2
scottmg
On 2013/07/29 21:48:39, jamesr wrote: > lgtm, but make sure the .exe has the right ...
7 years, 4 months ago (2013-07-29 21:50:09 UTC) #3
scottmg
7 years, 4 months ago (2013-07-29 21:52:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r214231 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698