Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2116383002: Revert of Disable failing smoke tests (Closed)

Created:
4 years, 5 months ago by Kunihiko Sakamoto
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable failing smoke tests (patchset #1 id:1 of https://codereview.chromium.org/2120193002/ ) Reason for revert: V8 roll r403621 may have been fixed the issue. Let's try re-enabling these tests. Original issue's description: > Disable failing benchmarks.system_health_smoke_tests > > Failing builders: > https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35135 > https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/55288 > > BUG=625506 > TBR=nednguyen@google.com,petrcermak@chromium.org > NOTRY=true > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq > > Committed: https://crrev.com/200b7600c99d19299b9e3990284782e7a7425662 > Cr-Commit-Position: refs/heads/master@{#403628} TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=625506 Committed: https://crrev.com/4e382440ac651af5aab42b5af00437c5a68df561 Cr-Commit-Position: refs/heads/master@{#403639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M tools/perf/benchmarks/system_health_smoke_test.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Kunihiko Sakamoto
Created Revert of Disable failing smoke tests
4 years, 5 months ago (2016-07-04 06:23:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116383002/1
4 years, 5 months ago (2016-07-04 06:23:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 06:24:25 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 06:25:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e382440ac651af5aab42b5af00437c5a68df561
Cr-Commit-Position: refs/heads/master@{#403639}

Powered by Google App Engine
This is Rietveld 408576698