Issue 211633002: Fix bug on android with GL_EXT_debug_marker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 211633002: Fix bug on android with GL_EXT_debug_marker (Closed)

Created:
6 years, 9 months ago by egdaniel

Modified:
6 years, 9 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Fix bug on android with GL_EXT_debug_marker A device was finding the extension string, but was returning NULL when getting the proc addresses BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13946

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nit #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
	M	src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp	View	1	5 chunks	+15 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bsalomon

lgtm https://codereview.chromium.org/211633002/diff/1/src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp File src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp (right): https://codereview.chromium.org/211633002/diff/1/src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp#newcode197 src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp:197: // The below check is here because device ...

6 years, 9 months ago (2014-03-25 20:31:02 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/211633002/70001

6 years, 9 months ago (2014-03-25 20:35:15 UTC) #4

Message was sent while issue was closed.

Change committed as 13946

Expand Messages | Collapse Messages