printing/units.h - Issue 2116283002: Don't let rounding prematurely influence document size when printing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/units.h

Issue 2116283002: Don't let rounding prematurely influence document size when printing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@620456-2

Patch Set: bug 467579 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/printing/renderer/print_web_view_helper.cc ('K') | « components/printing/renderer/print_web_view_helper.cc ('k') | printing/units.cc » ('j') | third_party/WebKit/public/web/WebFrame.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: printing/units.h

diff --git a/printing/units.h b/printing/units.h

index 72d2f7cd147294559434f1449668af31ff54279c..0e19d043c83c7bf68f94cc66e78ffe2f8d765d56 100644

--- a/printing/units.h

+++ b/printing/units.h

@@ -40,7 +40,7 @@ const float kA3WidthInch = 11.69f;

const float kA3HeightInch = 16.54f;

// Converts from one unit system to another using integer arithmetics.

-PRINTING_EXPORT int ConvertUnit(int value, int old_unit, int new_unit);

+PRINTING_EXPORT int ConvertUnit(double value, int old_unit, int new_unit);

// Converts from one unit system to another using doubles.

PRINTING_EXPORT double ConvertUnitDouble(double value, double old_unit,