Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1616)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 2116283002: Don't let rounding prematurely influence document size when printing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@620456-2
Patch Set: bug 467579 Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/dom/Document.cpp ('K') | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/page/PrintContext.cpp » ('j') | third_party/WebKit/Source/core/page/PrintContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutView.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutView.cpp b/third_party/WebKit/Source/core/layout/LayoutView.cpp
index 0fc2e4519123d7005a10b7863ab065341dc0b530..2363a95b2b9780d0c3cfc85998e50d8e5ed438f7 100644
--- a/third_party/WebKit/Source/core/layout/LayoutView.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutView.cpp
@@ -833,7 +833,9 @@ IntRect LayoutView::documentRect() const
{
LayoutRect overflowRect(layoutOverflowRect());
flipForWritingMode(overflowRect);
- return pixelSnappedIntRect(overflowRect);
+ return IntRect(roundedIntPoint(overflowRect.location()), IntSize(
+ floorToInt(overflowRect.width()),
eae 2016/07/12 22:26:39 This is incorrect. We do not floor sizes, we pixel
rhogan 2016/07/13 18:27:13 Yes, this is wrong.
+ floorToInt(overflowRect.height())));
}
bool LayoutView::rootBackgroundIsEntirelyFixed() const
« third_party/WebKit/Source/core/dom/Document.cpp ('K') | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/page/PrintContext.cpp » ('j') | third_party/WebKit/Source/core/page/PrintContext.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698