Use GCController.collectAll() in gc()

Use GCController.collectAll() in gc()
BUG=340522
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170014

[haraken, 2014-03-26 04:04:19]

Alternately, you can replace the implementation of gc() so that it uses
GCController.collectAll().

The replacement will affect other tests which use gc(), but it will be no harm.
Rather, it's a right thing to call GCController.collectAll() in gc(), because
call sites of gc() are expecting that gc() collects all garbage.

[kouhei (in TOK), 2014-03-26 04:09:59]

On 2014/03/26 04:04:19, haraken wrote:
> Alternately, you can replace the implementation of gc() so that it uses
> GCController.collectAll().
> 
> The replacement will affect other tests which use gc(), but it will be no
harm.
> Rather, it's a right thing to call GCController.collectAll() in gc(), because
> call sites of gc() are expecting that gc() collects all garbage.

Done.

[haraken, 2014-03-26 04:12:58]

LGTM.

In a follow-up CL, I'll look into all call sites which are calling gc() multiple
times and replace them with one gc().

[kouhei (in TOK), 2014-03-26 04:20:59]

On 2014/03/26 04:12:58, haraken wrote:
> LGTM.
> 
> In a follow-up CL, I'll look into all call sites which are calling gc()
multiple
> times and replace them with one gc().

I made a script that catches all possible callsites of calling gc() multiple
times, but the list is pretty huge.

[kouhei (in TOK), 2014-03-26 04:21:15]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-03-26 04:21:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kouhei@chromium.org/211623006/2

[commit-bot: I haz the power, 2014-03-26 04:21:36]

Change committed as 170014

[haraken, 2014-03-26 04:24:10]

On 2014/03/26 04:20:59, kouhei wrote:
> On 2014/03/26 04:12:58, haraken wrote:
> > LGTM.
> > 
> > In a follow-up CL, I'll look into all call sites which are calling gc()
> multiple
> > times and replace them with one gc().
> 
> I made a script that catches all possible callsites of calling gc() multiple
> times, but the list is pretty huge.

Great, thanks. I appreciate if you could replace them with the multiple gc()s
with one gc(). But please just be careful that the gc() is the gc() in
js-test.js. Some tests define gc() manually.