Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Unified Diff: chrome/test/base/js2gtest.gni

Issue 2116183002: Land chromium-side work to clean up handling of v8_target_cpu in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix missing import Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/linux/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/js2gtest.gni
diff --git a/chrome/test/base/js2gtest.gni b/chrome/test/base/js2gtest.gni
index c4fde1f4865dd02e3155c6c28264130c70037b88..50d3c8459e19bb7f549d5dda53121960c3c0c23b 100644
--- a/chrome/test/base/js2gtest.gni
+++ b/chrome/test/base/js2gtest.gni
@@ -37,7 +37,7 @@ template("js2gtest") {
sources = invoker.sources
- v8_shell_path = get_label_info("//v8:v8_shell($snapshot_toolchain)",
+ v8_shell_path = get_label_info("//v8:v8_shell($v8_snapshot_toolchain)",
"root_out_dir") + "/v8_shell"
if (is_win) {
v8_shell_path += ".exe"
@@ -90,7 +90,7 @@ template("js2gtest") {
]
deps = [
- "//v8:v8_shell($snapshot_toolchain)",
+ "//v8:v8_shell($v8_snapshot_toolchain)",
]
if (defined(invoker.deps)) {
deps += invoker.deps
« no previous file with comments | « build/toolchain/linux/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698