build/config/arm.gni - Issue 2116183002: Land chromium-side work to clean up handling of v8_target_cpu in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/arm.gni

Issue 2116183002: Land chromium-side work to clean up handling of v8_target_cpu in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix missing import Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/arm.gni

diff --git a/build/config/arm.gni b/build/config/arm.gni

index 326a49ece16530816b979cacec9e70b265284c1b..cc468d89e18e21b0c123d6fa9476a008471f0474 100644

--- a/build/config/arm.gni

+++ b/build/config/arm.gni

@@ -8,7 +8,7 @@ import("//build/config/v8_target_cpu.gni")

# ARM code is being compiled. But they can also be relevant in the

# other contexts when the code will change its behavior based on the

# cpu it wants to generate code for.

-if (current_cpu == "arm" || v8_target_cpu == "arm") {

+if (current_cpu == "arm" || v8_current_cpu == "arm") {

declare_args() {

# Version of the ARM processor when compiling on ARM. Ignored on non-ARM

# platforms.

@@ -87,7 +87,7 @@ if (current_cpu == "arm" || v8_target_cpu == "arm") {

arm_fpu = "vfpv3-d16"

}

-} else if (current_cpu == "arm64" || v8_target_cpu == "arm64") {

+} else if (current_cpu == "arm64" || v8_current_cpu == "arm64") {

# arm64 supports only "hard".

arm_float_abi = "hard"

arm_use_neon = true

« no previous file with comments | « BUILD.gn ('k') | build/config/mips.gni » ('j') | no next file with comments »