Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: build/config/v8_target_cpu.gni

Issue 2116183002: Land chromium-side work to clean up handling of v8_target_cpu in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4 #
5 import("//build/config/sanitizers/sanitizers.gni") 5 # TODO(crbug.com/621581): Remove this file once v8 no longer references it.
6
7 declare_args() {
8 # This arg is used when we want to tell the JIT-generating v8 code
9 # that we want to have it generate for an architecture that is different
10 # than the architecture that v8 will actually run on; we then run the
11 # code under an emulator. For example, we might run v8 on x86, but
12 # generate arm code and run that under emulation.
13 #
14 # This arg is defined here rather than in the v8 project because we want
15 # some of the common architecture-specific args (like arm_float_abi or
16 # mips_arch_variant) to be set to their defaults either if the current_cpu
17 # applies *or* if the v8_target_cpu applies.
18 #
19 # TODO(crbug.com/620527) - rework this whole approach so that it isn't
20 # v8-specific.
21 v8_target_cpu = ""
22 }
23
24 if (v8_target_cpu == "") {
25 if (is_msan) {
26 # Running the V8-generated code on an ARM simulator is a powerful hack that
27 # allows the tool to see the memory accesses from JITted code. Without this
28 # flag, JS code causes false positive reports from MSan.
29 v8_target_cpu = "arm64"
30 } else {
31 v8_target_cpu = target_cpu
32 }
33 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698