Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1851)

Unified Diff: base/task_scheduler/task_scheduler_impl_unittest.cc

Issue 2116163002: Add Lazy Creation and Thread Detachment Support in the Scheduler Worker Pool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR Feedback Continuation Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/task_scheduler_impl_unittest.cc
diff --git a/base/task_scheduler/task_scheduler_impl_unittest.cc b/base/task_scheduler/task_scheduler_impl_unittest.cc
index aa519a8ee054e26cc9c369a0e9d3395ff8bd5f2b..e4b925d2c1173b2fec7c6efa8ebcff025db346ca 100644
--- a/base/task_scheduler/task_scheduler_impl_unittest.cc
+++ b/base/task_scheduler/task_scheduler_impl_unittest.cc
@@ -23,6 +23,7 @@
#include "base/threading/simple_thread.h"
#include "base/threading/thread.h"
#include "base/threading/thread_restrictions.h"
+#include "base/time/time.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace base {
@@ -165,19 +166,20 @@ class TaskSchedulerImplTest
ASSERT_EQ(BACKGROUND_WORKER_POOL, params.size());
params.emplace_back("TaskSchedulerBackground", ThreadPriority::BACKGROUND,
- IORestriction::DISALLOWED, 1U);
+ IORestriction::DISALLOWED, 1U, TimeDelta::Max());
ASSERT_EQ(BACKGROUND_FILE_IO_WORKER_POOL, params.size());
params.emplace_back("TaskSchedulerBackgroundFileIO",
- ThreadPriority::BACKGROUND, IORestriction::ALLOWED, 3U);
+ ThreadPriority::BACKGROUND, IORestriction::ALLOWED, 3U,
+ TimeDelta::Max());
ASSERT_EQ(FOREGROUND_WORKER_POOL, params.size());
params.emplace_back("TaskSchedulerForeground", ThreadPriority::NORMAL,
- IORestriction::DISALLOWED, 4U);
+ IORestriction::DISALLOWED, 4U, TimeDelta::Max());
ASSERT_EQ(FOREGROUND_FILE_IO_WORKER_POOL, params.size());
params.emplace_back("TaskSchedulerForegroundFileIO", ThreadPriority::NORMAL,
- IORestriction::ALLOWED, 12U);
+ IORestriction::ALLOWED, 12U, TimeDelta::Max());
scheduler_ = TaskSchedulerImpl::Create(params,
Bind(&GetThreadPoolIndexForTraits));

Powered by Google App Engine
This is Rietveld 408576698