base/task_scheduler/scheduler_service_thread_unittest.cc - Issue 2116163002: Add Lazy Creation and Thread Detachment Support in the Scheduler Worker Pool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task_scheduler/scheduler_service_thread_unittest.cc

Issue 2116163002: Add Lazy Creation and Thread Detachment Support in the Scheduler Worker Pool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/task_scheduler/scheduler_service_thread_unittest.cc

diff --git a/base/task_scheduler/scheduler_service_thread_unittest.cc b/base/task_scheduler/scheduler_service_thread_unittest.cc

index c2a4162bd643841935cc488c45d142bb867f7f4e..bbf904c53c093c0061c662f271325bbe131e655c 100644

--- a/base/task_scheduler/scheduler_service_thread_unittest.cc

+++ b/base/task_scheduler/scheduler_service_thread_unittest.cc

@@ -56,7 +56,7 @@ class TaskSchedulerServiceThreadTest : public testing::Test {

scheduler_worker_pool_ = SchedulerWorkerPoolImpl::Create(

"TestWorkerPoolForSchedulerServiceThread", ThreadPriority::BACKGROUND,

1u, SchedulerWorkerPoolImpl::IORestriction::DISALLOWED,

- Bind(&ReEnqueueSequenceCallback), &task_tracker_,

+ TimeDelta::Max(), Bind(&ReEnqueueSequenceCallback), &task_tracker_,

&delayed_task_manager_);

ASSERT_TRUE(scheduler_worker_pool_);

service_thread_ = SchedulerServiceThread::Create(

« no previous file with comments | « no previous file | base/task_scheduler/scheduler_worker_pool_impl.h » ('j') | base/task_scheduler/scheduler_worker_pool_impl.h » ('J')