Initialize DBus in mojo:ash on chrome os

Initialize DBus in mojo:ash on chrome os

This fixes a crash when running mash_unittests. Also add back initialization
of MaximizeModeController on mus, which was removed to avoid the crash.

BUG=612629
TEST=mash_unittests

Committed: https://crrev.com/6eff4c6df93fd22ce101d61883f77fe50df89ea1
Cr-Commit-Position: refs/heads/master@{#404257}

[James Cook, 2016-07-01 23:17:36]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-07-01 23:17:36]

sky, please take a look.

https://codereview.chromium.org/2116153002/diff/1/ash/mus/window_manager_appl...
File ash/mus/window_manager_application.cc (right):

https://codereview.chromium.org/2116153002/diff/1/ash/mus/window_manager_appl...
ash/mus/window_manager_application.cc:36:
chromeos::DBusThreadManager::Initialize();
I put this here instead of in WMA::Initialize() because WmTestHelper doesn't
call WMA::Initialize().

[James Cook, 2016-07-01 23:58:19]

Description was changed from

==========
Initialize DBus in mojo:ash on chrome os

This fixes a crash when running mash_unittests.

BUG=612629
TEST=mash_unittests
==========

to

==========
Initialize DBus in mojo:ash on chrome os

This fixes a crash when running mash_unittests. Also add back initialization
of MaximizeModeController on mus, which was removed to avoid the crash.

BUG=612629
TEST=mash_unittests
==========

[sky, 2016-07-04 23:49:20]

LGTM

[James Cook, 2016-07-06 15:32:24]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-07-06 15:32:24]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2116153002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-06 15:32:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 16:51:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 16:51:56]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-07-07 18:23:39]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 18:24:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 19:25:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 19:25:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-07-07 19:59:03]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 19:59:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-07-07 20:10:11]

sky, can you take another look?

Previously I was initializing DBus too early, before mojo::ApplicationRunner had
a chance to initialize the AtExitManager. Doing it in this location works for
both "real" window manager startup and initialization in tests (via
WmTestHelper).

[commit-bot: I haz the power, 2016-07-07 21:53:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 21:53:44]

Dry run: This issue passed the CQ dry run.

[sky, 2016-07-07 21:56:43]

LGTM

[James Cook, 2016-07-07 22:12:45]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-07-07 22:13:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 22:21:06]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-07 22:23:36]

Description was changed from

==========
Initialize DBus in mojo:ash on chrome os

This fixes a crash when running mash_unittests. Also add back initialization
of MaximizeModeController on mus, which was removed to avoid the crash.

BUG=612629
TEST=mash_unittests
==========

to

==========
Initialize DBus in mojo:ash on chrome os

This fixes a crash when running mash_unittests. Also add back initialization
of MaximizeModeController on mus, which was removed to avoid the crash.

BUG=612629
TEST=mash_unittests

Committed: https://crrev.com/6eff4c6df93fd22ce101d61883f77fe50df89ea1
Cr-Commit-Position: refs/heads/master@{#404257}
==========

[commit-bot: I haz the power, 2016-07-07 22:23:38]

Patchset 4 (id:??) landed as
https://crrev.com/6eff4c6df93fd22ce101d61883f77fe50df89ea1
Cr-Commit-Position: refs/heads/master@{#404257}