[repaint-after-layout] Skip full repaint if the style difference is layout.

[repaint-after-layout] Skip full repaint if the style difference is layout.

Currently in RenderBox::styleWillChange we will issue a view()->repaint() if the
node is the HTML or body element and the diff >= StyleDifferenceRepaint. For
repaint-after-layout, if this is StyleDifferenceLayout, we will do the layout
and end up issuing the same invalidation again.

This CL makes the view()->repaint() call conditional on either
  1) repaint-after-layout is disabled
  2) this is not a StyleDifferenceLayout.

BUG=320139
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169984

[dsinclair, 2014-03-25 19:33:17]

PTAL.

[esprehn, 2014-03-25 19:35:15]

lgtm, but why does it matter if we issue duplicate invalidations?

[dsinclair, 2014-03-25 19:39:27]

On 2014/03/25 19:35:15, esprehn wrote:
> lgtm, but why does it matter if we issue duplicate invalidations?


Performance wise, as far as I know, it doesn't matter. From a debugging point of
view, it's easier (at least for me) to track down over-invalidation if we're
spitting out fewer invalidation rects.

[dsinclair, 2014-03-25 19:43:59]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2014-03-25 19:44:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dsinclair@chromium.org/211613002/1

[commit-bot: I haz the power, 2014-03-25 21:53:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-25 21:53:45]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[esprehn, 2014-03-25 21:55:41]

fast/dom/shadow/access-document-of-detached-stylesheetlist-crash.html

failed twice, was that you?

[dsinclair, 2014-03-25 22:47:19]

I don't think so.  It crashed in the dom window destructor in part of the
v8 garbage collection. I'll run the test locally tomorrow and see what
happens.

Dan
On Mar 25, 2014 5:55 PM, <esprehn@chromium.org> wrote:

> fast/dom/shadow/access-document-of-detached-stylesheetlist-crash.html
>
> failed twice, was that you?
>
> https://codereview.chromium.org/211613002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[esprehn, 2014-03-25 23:10:08]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-25 23:10:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dsinclair@chromium.org/211613002/1

[commit-bot: I haz the power, 2014-03-26 00:12:01]

Change committed as 169984

[leviw_travelin_and_unemployed, 2014-04-22 22:13:18]

On 2014/03/26 00:12:01, I haz the power (commit-bot) wrote:
> Change committed as 169984

This doesn't quite work, sadly. view()->repaint() invalidates the entire
viewport, which is necessary for the root the way we paint root backgrounds
since the renderer that will be laid out doesn't necessary cover the viewport.
We currently fail fast/repaint/positioned-document-element.html due to this
change.

[dsinclair, 2014-04-22 23:38:32]

A revert of this CL has been created in
https://codereview.chromium.org/246393009/ by dsinclair@chromium.org.

The reason for reverting is: Breaks
fast/repaint/positioned-document-element.html..