Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2116123002: MD Settings: fix clear browsing data dialog (again) (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix clear browsing data dialog (again) R=dpapad@chromium.org BUG=625320 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/4245543d64ef375474db34897fe5e6da62c0d4fe Cr-Commit-Position: refs/heads/master@{#403571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/resources/settings/privacy_page/privacy_page.js View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Dan Beam
4 years, 5 months ago (2016-07-01 23:10:28 UTC) #2
dpapad
lgtm
4 years, 5 months ago (2016-07-01 23:18:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116123002/1
4 years, 5 months ago (2016-07-01 23:28:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-02 00:08:45 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-02 00:11:18 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4245543d64ef375474db34897fe5e6da62c0d4fe
Cr-Commit-Position: refs/heads/master@{#403571}

Powered by Google App Engine
This is Rietveld 408576698