Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerGlobalScope.h

Issue 2116113002: [worklets] Make WorkerThread handle both Worker and Worklet global scopes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase again Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
diff --git a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
index 41e684d2fb4067af80fa0e2737c9e0542bd17426..4c3dfdec50564cc3e9ded9f24dd15e51c062865a 100644
--- a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
+++ b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
@@ -75,7 +75,7 @@ public:
virtual CachedMetadataHandler* createWorkerScriptCachedMetadataHandler(const KURL& scriptURL, const Vector<char>* metaData) { return nullptr; }
KURL completeURL(const String&) const;
- void dispose();
+ void dispose() final;
void exceptionUnhandled(const String& errorMessage, std::unique_ptr<SourceLocation>);
void registerEventListener(V8AbstractEventListener*);
@@ -120,11 +120,7 @@ public:
return const_cast<WorkerGlobalScope*>(this);
}
- // Returns true when the WorkerGlobalScope is closing (e.g. via close()
- // method). If this returns true, the worker is going to be shutdown after
- // the current task execution. Workers that don't support close operation
- // should always return false.
- bool isClosing() const { return m_closing; }
+ bool isClosing() const final { return m_closing; }
const KURL& url() const { return m_url; }
WorkerThread* thread() const { return m_thread; }

Powered by Google App Engine
This is Rietveld 408576698