third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp - Issue 2116113002: [worklets] Make WorkerThread handle both Worker and Worklet global scopes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

Issue 2116113002: [worklets] Make WorkerThread handle both Worker and Worklet global scopes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase again Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp ('k') | third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

diff --git a/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp b/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

index 12c2f298ede542afb758eef971326a66d5445a1a..aa2358c9ff5c9ed77e601ffc22e3da029b24a812 100644

--- a/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

+++ b/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

@@ -286,9 +286,9 @@ private:

// ThreadableLoader::create() determines whether it should create

// a DocumentThreadableLoader or WorkerThreadableLoader based on

// isWorkerGlobalScope().

- ASSERT(m_workerThread->workerGlobalScope()->isWorkerGlobalScope());

+ DCHECK(m_workerThread->globalScope()->isWorkerGlobalScope());

- m_loader = ThreadableLoader::create(*m_workerThread->workerGlobalScope(), client, options, resourceLoaderOptions);

+ m_loader = ThreadableLoader::create(*m_workerThread->globalScope(), client, options, resourceLoaderOptions);

ASSERT(m_loader);

event->signal();

}