third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h - Issue 2116113002: [worklets] Make WorkerThread handle both Worker and Worklet global scopes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h

Issue 2116113002: [worklets] Make WorkerThread handle both Worker and Worklet global scopes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp ('k') | third_party/WebKit/Source/core/workers/WorkerReportingProxy.h » ('j') | third_party/WebKit/Source/core/workers/WorkerReportingProxy.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h

diff --git a/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h b/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h

index 0127a065141280b0587431d5274464925a8153ee..fa9c16f27b306f2a36d84cd2ebbf53c875871357 100644

--- a/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h

+++ b/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h

@@ -16,6 +16,8 @@ class CORE_EXPORT WorkerOrWorkletGlobalScope : public ExecutionContext {

public:

virtual ScriptWrappable* getScriptWrappable() const = 0;

virtual WorkerOrWorkletScriptController* scriptController() = 0;

+ virtual bool isClosing() const = 0;

yhirano 2016/07/22 06:23:40 Could you add comments for these new functions?

ikilpatrick 2016/07/22 18:21:59 Done.

+ virtual void dispose() = 0;

kinuko 2016/07/22 05:44:34 comments?

ikilpatrick 2016/07/22 18:21:59 Done.

};

DEFINE_TYPE_CASTS(WorkerOrWorkletGlobalScope, ExecutionContext, context, (context->isWorkerGlobalScope() || context->isWorkletGlobalScope()), (context.isWorkerGlobalScope() || context.isWorkletGlobalScope()));