appengine/findit/waterfall/build_util.py - Issue 2116073002: [Findit] Fix redirect bug and update template for waterfall/culprit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/build_util.py

Issue 2116073002: [Findit] Fix redirect bug and update template for waterfall/culprit. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Use build end time to check whether too late to send notification. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/build_info.py ('k') | appengine/findit/waterfall/buildbot.py » ('j') | appengine/findit/waterfall/send_notification_for_culprit_pipeline.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/build_util.py

diff --git a/appengine/findit/waterfall/build_util.py b/appengine/findit/waterfall/build_util.py

index 362f6114eff9caea10cde03413dae7bcf8ef85e1..a9d7823131a8f0f44238c46483a3d9d94421ecfd 100644

--- a/appengine/findit/waterfall/build_util.py

+++ b/appengine/findit/waterfall/build_util.py

@@ -55,3 +55,10 @@ def DownloadBuildData(master_name, builder_name, build_number):

build.put()

return build

+def GetBuildEndTime(master_name, builder_name, build_number):

+ build_data = DownloadBuildData(master_name, builder_name, build_number)

+ build_info = buildbot.ExtractBuildInfo(

+ master_name, builder_name, build_number, build_data)

+ return build_info.build_end_time