[Findit] Fix redirect bug and update template for waterfall/culprit.

appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py

Index: appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py
diff --git a/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py b/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py
index c625caa0a929162025d0a86d7903170bcbdbbc56..5a68865d96a16674fbceae58cdb040a4a31dfdb2 100644
--- a/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py
+++ b/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py
@@ -31,9 +31,15 @@ class SendNotificationForCulpritPipelineTest(wf_testcase.WaterfallTestCase):
         @property
         def code_review_url(self):
           return mocked_url
+
         @property
         def committer_time(self):
           return _MOCKED_COMMIT_TIME
+
+        @property
+        def commit_position(self):
+          return 123
+
       return MockedChangeLog()
     self.mock(GitRepository, 'GetChangeLog', Mocked_GetChangeLog)
 
@@ -48,7 +54,7 @@ class SendNotificationForCulpritPipelineTest(wf_testcase.WaterfallTestCase):
   def testShouldNotSendNotificationForSingleFailedBuild(self):
     self.assertFalse(
         send_notification_for_culprit_pipeline._ShouldSendNotification(
-            'm', 'b1', 1, 'chromium', 'r1', 2, False))
+            'm', 'b1', 1, 'chromium', 'r1', 123, 2, False))
     culprit = WfCulprit.Get('chromium', 'r1')
     self.assertIsNotNone(culprit)
     self.assertEqual([['m', 'b1', 1]], culprit.builds)
@@ -56,10 +62,10 @@ class SendNotificationForCulpritPipelineTest(wf_testcase.WaterfallTestCase):
   def testShouldNotSendNotificationForSameFailedBuild(self):
     self.assertFalse(
         send_notification_for_culprit_pipeline._ShouldSendNotification(
-            'm', 'b2', 2, 'chromium', 'r2', 2, False))
+            'm', 'b2', 2, 'chromium', 'r2', 123, 2, False))
     self.assertFalse(
         send_notification_for_culprit_pipeline._ShouldSendNotification(
-            'm', 'b2', 2, 'chromium', 'r2', 2, False))
+            'm', 'b2', 2, 'chromium', 'r2', 123, 2, False))
     culprit = WfCulprit.Get('chromium', 'r2')
     self.assertIsNotNone(culprit)
     self.assertEqual([['m', 'b2', 2]], culprit.builds)
@@ -67,10 +73,10 @@ class SendNotificationForCulpritPipelineTest(wf_testcase.WaterfallTestCase):
   def testShouldSendNotificationForSecondFailedBuild(self):
     self.assertFalse(
         send_notification_for_culprit_pipeline._ShouldSendNotification(
-            'm', 'b31', 31, 'chromium', 'r3', 2, False))
+            'm', 'b31', 31, 'chromium', 'r3', 123, 2, False))
     self.assertTrue(
         send_notification_for_culprit_pipeline._ShouldSendNotification(
-            'm', 'b32', 32, 'chromium', 'r3', 2, False))
+            'm', 'b32', 32, 'chromium', 'r3', 123, 2, False))
     culprit = WfCulprit.Get('chromium', 'r3')
     self.assertIsNotNone(culprit)
     self.assertEqual(status.RUNNING, culprit.cr_notification_status)
@@ -91,7 +97,7 @@ class SendNotificationForCulpritPipelineTest(wf_testcase.WaterfallTestCase):
     self._MockRietveld(rietveld_requests)
     self._MockGitRepository(None)
     self._MockDatetimeUtcNow()
-    culprit = WfCulprit.Create('chromium', 'r5')
+    culprit = WfCulprit.Create('chromium', 'r5', 123)
     culprit.builds.append(['m', 'b51', 51])
     culprit.put()
 
@@ -104,7 +110,7 @@ class SendNotificationForCulpritPipelineTest(wf_testcase.WaterfallTestCase):
     self._MockRietveld(rietveld_requests)
     self._MockGitRepository('url')
     self._MockDatetimeUtcNow()
-    culprit = WfCulprit.Create('chromium', 'r6')
+    culprit = WfCulprit.Create('chromium', 'r6', 123)
     culprit.builds.append(['m', 'b61', 61])
     culprit.put()