Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2116053003: [esnext] ship --harmony-object-values-entries (Closed)

Created:
4 years, 5 months ago by caitp (gmail)
Modified:
4 years, 5 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[esnext] ship --harmony-object-values-entries BUG=v8:4663 R=littledan@chromium.org, adamk@chromium.org Committed: https://crrev.com/ab529234853a1768642f8f6c907aaaa5ea8b19bf Cr-Commit-Position: refs/heads/master@{#37485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/flag-definitions.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116053003/1
4 years, 5 months ago (2016-07-01 22:48:41 UTC) #2
caitp (gmail)
PTAL --- The intent thread never got 3 LGTMs, but this may serve as a ...
4 years, 5 months ago (2016-07-01 22:49:35 UTC) #3
adamk
lgtm
4 years, 5 months ago (2016-07-01 22:51:46 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-01 23:14:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116053003/1
4 years, 5 months ago (2016-07-01 23:16:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 23:18:25 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ab529234853a1768642f8f6c907aaaa5ea8b19bf Cr-Commit-Position: refs/heads/master@{#37485}
4 years, 5 months ago (2016-07-01 23:20:17 UTC) #11
Dan Ehrenberg
4 years, 5 months ago (2016-07-06 22:39:29 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2129533004/ by littledan@chromium.org.

The reason for reverting is: Revert to see if it addresses the performance
regression observed in chromium:625956 in automated graphs.

Powered by Google App Engine
This is Rietveld 408576698