Extend HoverHighlightView

Extend HoverHighlightView

Add some new features to HoverHighlightView:

- Allow text label to grow in size in HoverHighlightView
- Allow the highlight (bold font) state to be changed dynamically
- Add support for an optional right-justified icon.

This is needed for the palette tray tools, introduced in https://codereview.chromium.org/2147783002/.

BUG=625251
Committed: https://crrev.com/6d15df311c2b1772ef8ee4dfa45fc9c6cb2faa94
Cr-Commit-Position: refs/heads/master@{#405341}

[jdufault, 2016-07-01 19:18:07]

Patchset #1 (id:1) has been deleted

[jdufault, 2016-07-01 19:20:07]

Patchset #1 (id:20001) has been deleted

[jdufault, 2016-07-12 21:17:14]

Patchset #2 (id:60001) has been deleted

[jdufault, 2016-07-12 21:17:19]

Patchset #1 (id:40001) has been deleted

[jdufault, 2016-07-12 23:41:20]

Patchset #1 (id:80001) has been deleted

[jdufault, 2016-07-12 23:42:39]

Description was changed from

==========
Allow text label to grow in size in HoverHighlightView

BUG=625251
==========

to

==========
Extend HoverHighlightView

Add some new features to HoverHighlightView:

- Allow text label to grow in size in HoverHighlightView
- Allow the highlight (bold font) state to be changed dynamically
- Add support for an optional right-justified icon.

BUG=625251
==========

[jdufault, 2016-07-12 23:56:42]

Description was changed from

==========
Extend HoverHighlightView

Add some new features to HoverHighlightView:

- Allow text label to grow in size in HoverHighlightView
- Allow the highlight (bold font) state to be changed dynamically
- Add support for an optional right-justified icon.

BUG=625251
==========

to

==========
Extend HoverHighlightView

Add some new features to HoverHighlightView:

- Allow text label to grow in size in HoverHighlightView
- Allow the highlight (bold font) state to be changed dynamically
- Add support for an optional right-justified icon.

This is needed for the palette tray tools, introduced in
https://codereview.chromium.org/2147783002/.

BUG=625251
==========

[jdufault, 2016-07-13 18:48:35]

jdufault@chromium.org changed reviewers:
+ stevenjb@chromium.org

[jdufault, 2016-07-13 18:49:05]

Steven, PTAL. Thanks!

[stevenjb, 2016-07-13 19:51:02]

lgtm w/ nits

https://codereview.chromium.org/2116033002/diff/100001/ash/common/system/tray...
File ash/common/system/tray/hover_highlight_view.cc (right):

https://codereview.chromium.org/2116033002/diff/100001/ash/common/system/tray...
ash/common/system/tray/hover_highlight_view.cc:52: DCHECK(box_layout_);
DCHECK(!right_icon_)

https://codereview.chromium.org/2116033002/diff/100001/ash/common/system/tray...
ash/common/system/tray/hover_highlight_view.cc:61: if (right_icon_) {
nit: invert and early exit

[jdufault, 2016-07-13 21:53:50]

Thanks for taking a look!

https://codereview.chromium.org/2116033002/diff/100001/ash/common/system/tray...
File ash/common/system/tray/hover_highlight_view.cc (right):

https://codereview.chromium.org/2116033002/diff/100001/ash/common/system/tray...
ash/common/system/tray/hover_highlight_view.cc:52: DCHECK(box_layout_);
On 2016/07/13 19:51:01, stevenjb wrote:
> DCHECK(!right_icon_)

Done.

https://codereview.chromium.org/2116033002/diff/100001/ash/common/system/tray...
ash/common/system/tray/hover_highlight_view.cc:61: if (right_icon_) {
On 2016/07/13 19:51:01, stevenjb wrote:
> nit: invert and early exit

Done.

[jdufault, 2016-07-13 21:53:53]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-07-13 21:53:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2116033002/#ps120001
(title: "Address nits")

[commit-bot: I haz the power, 2016-07-13 21:54:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 23:09:16]

Description was changed from

==========
Extend HoverHighlightView

Add some new features to HoverHighlightView:

- Allow text label to grow in size in HoverHighlightView
- Allow the highlight (bold font) state to be changed dynamically
- Add support for an optional right-justified icon.

This is needed for the palette tray tools, introduced in
https://codereview.chromium.org/2147783002/.

BUG=625251
==========

to

==========
Extend HoverHighlightView

Add some new features to HoverHighlightView:

- Allow text label to grow in size in HoverHighlightView
- Allow the highlight (bold font) state to be changed dynamically
- Add support for an optional right-justified icon.

This is needed for the palette tray tools, introduced in
https://codereview.chromium.org/2147783002/.

BUG=625251
==========

[commit-bot: I haz the power, 2016-07-13 23:09:17]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-07-13 23:12:05]

Description was changed from

==========
Extend HoverHighlightView

Add some new features to HoverHighlightView:

- Allow text label to grow in size in HoverHighlightView
- Allow the highlight (bold font) state to be changed dynamically
- Add support for an optional right-justified icon.

This is needed for the palette tray tools, introduced in
https://codereview.chromium.org/2147783002/.

BUG=625251
==========

to

==========
Extend HoverHighlightView

Add some new features to HoverHighlightView:

- Allow text label to grow in size in HoverHighlightView
- Allow the highlight (bold font) state to be changed dynamically
- Add support for an optional right-justified icon.

This is needed for the palette tray tools, introduced in
https://codereview.chromium.org/2147783002/.

BUG=625251

Committed: https://crrev.com/6d15df311c2b1772ef8ee4dfa45fc9c6cb2faa94
Cr-Commit-Position: refs/heads/master@{#405341}
==========

[commit-bot: I haz the power, 2016-07-13 23:12:06]

Patchset 2 (id:??) landed as
https://crrev.com/6d15df311c2b1772ef8ee4dfa45fc9c6cb2faa94
Cr-Commit-Position: refs/heads/master@{#405341}