Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2116013002: Convert video-controls* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-controls* tests to testharness.js Cleaning up video-controls* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/544b99fe2c3a445dfdc1e3bbc3a70eb58626eea0 Cr-Commit-Position: refs/heads/master@{#403607}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Messages

Total messages: 12 (6 generated)
Srirama
PTAL
4 years, 5 months ago (2016-07-01 18:34:28 UTC) #3
fs
LGTM w/ the below fixed https://codereview.chromium.org/2116013002/diff/1/third_party/WebKit/LayoutTests/media/video-controls-touch-events-captured.html File third_party/WebKit/LayoutTests/media/video-controls-touch-events-captured.html (right): https://codereview.chromium.org/2116013002/diff/1/third_party/WebKit/LayoutTests/media/video-controls-touch-events-captured.html#newcode28 third_party/WebKit/LayoutTests/media/video-controls-touch-events-captured.html:28: touchMediaControl("timeline"); This part did ...
4 years, 5 months ago (2016-07-01 19:17:29 UTC) #4
Srirama
https://codereview.chromium.org/2116013002/diff/1/third_party/WebKit/LayoutTests/media/video-controls-touch-events-captured.html File third_party/WebKit/LayoutTests/media/video-controls-touch-events-captured.html (right): https://codereview.chromium.org/2116013002/diff/1/third_party/WebKit/LayoutTests/media/video-controls-touch-events-captured.html#newcode28 third_party/WebKit/LayoutTests/media/video-controls-touch-events-captured.html:28: touchMediaControl("timeline"); On 2016/07/01 19:17:28, fs wrote: > This part ...
4 years, 5 months ago (2016-07-02 03:48:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116013002/20001
4 years, 5 months ago (2016-07-02 03:48:53 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-02 05:10:28 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-02 05:11:46 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/544b99fe2c3a445dfdc1e3bbc3a70eb58626eea0
Cr-Commit-Position: refs/heads/master@{#403607}

Powered by Google App Engine
This is Rietveld 408576698