Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2115933002: Revert of Added tests and reworked ink-drop touch logic (Closed)

Created:
4 years, 5 months ago by kelvinp
Modified:
4 years, 5 months ago
Reviewers:
kylix_rd, bruthig
CC:
chromium-reviews, tfarina, bruthig+ink_drop_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added tests and reworked ink-drop touch logic (patchset #2 id:20001 of https://codereview.chromium.org/2117603002/ ) Reason for revert: Compilation failure on Chromium.win builder. https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds/22983/steps/compile/logs/stdio Original issue's description: > Added tests and reworked ink-drop touch logic > > BUG=595315 > > Committed: https://crrev.com/fff99399f7fcfe17950174897fb47a26f6047c78 > Cr-Commit-Position: refs/heads/master@{#403462} TBR=bruthig@chromium.org,kylixrd@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=595315 Committed: https://crrev.com/82397d9c36b76e2869ab77ede2df736871c752b2 Cr-Commit-Position: refs/heads/master@{#403466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -79 lines) Patch
M ui/views/animation/ink_drop_host_view.cc View 1 chunk +16 lines, -9 lines 0 comments Download
M ui/views/animation/ink_drop_host_view_unittest.cc View 3 chunks +1 line, -70 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kelvinp
Created Revert of Added tests and reworked ink-drop touch logic
4 years, 5 months ago (2016-07-01 16:31:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115933002/1
4 years, 5 months ago (2016-07-01 16:31:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 16:32:36 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 16:32:40 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 16:34:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82397d9c36b76e2869ab77ede2df736871c752b2
Cr-Commit-Position: refs/heads/master@{#403466}

Powered by Google App Engine
This is Rietveld 408576698