Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: runtime/vm/scavenger.h

Issue 211593004: Reduce GC from external allocation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/scavenger.h
===================================================================
--- runtime/vm/scavenger.h (revision 34384)
+++ runtime/vm/scavenger.h (working copy)
@@ -160,14 +160,12 @@
// not consume space in the to space they leave enough room for this stack.
void PushToPromotedStack(uword addr) {
ASSERT(scavenging_);
- ASSERT(external_size_ == 0);
end_ -= sizeof(addr);
ASSERT(end_ > top_);
*reinterpret_cast<uword*>(end_) = addr;
}
uword PopFromPromotedStack() {
ASSERT(scavenging_);
- ASSERT(external_size_ == 0);
uword result = *reinterpret_cast<uword*>(end_);
end_ += sizeof(result);
ASSERT(end_ <= to_->end());
@@ -175,7 +173,6 @@
}
bool PromotedStackHasMore() const {
ASSERT(scavenging_);
- ASSERT(external_size_ == 0);
return end_ < to_->end();
}
@@ -211,7 +208,6 @@
intptr_t collections_;
// The total size of external data associated with objects in this scavenger.
- // External allocations decrease end_. If promoted stack is in use, this is 0.
intptr_t external_size_;
friend class ScavengerVisitor;
« runtime/vm/heap.cc ('K') | « runtime/vm/heap.cc ('k') | runtime/vm/scavenger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698