Reduce GC from external allocation.

runtime/vm/dart_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/builtin.h"
 #include "include/dart_api.h"
 #include "include/dart_debugger_api.h"
 #include "include/dart_mirrors_api.h"
 #include "include/dart_native_api.h"
 #include "platform/assert.h"
@@ skipping 2288 matching lines @@
   GCTestHelper::CollectNewSpace(Heap::kIgnoreApiCallbacks);
   GCTestHelper::CollectNewSpace(Heap::kIgnoreApiCallbacks);
   EXPECT(heap->ExternalInWords(Heap::kNew) == 0);
   EXPECT(heap->ExternalInWords(Heap::kOld) == kWeakExternalSize / kWordSize);
   Isolate::Current()->heap()->CollectGarbage(Heap::kOld);
   EXPECT(heap->ExternalInWords(Heap::kOld) == 0);
 }
 
 
 TEST_CASE(WeakPersistentHandleExternalAllocationSizeOversized) {
+  Dart_Isolate isolate = reinterpret_cast<Dart_Isolate>(Isolate::Current());
   Heap* heap = Isolate::Current()->heap();
   Dart_WeakPersistentHandle weak1 = NULL;
-  const intptr_t kWeak1ExternalSize = 100 * MB;
+  // Large enough to exceed any new space limit. Not actually allocated.
+  const intptr_t kWeak1ExternalSize = 500 * MB;
   {
     Dart_EnterScope();
     Dart_Handle obj = NewString("weakly referenced string");
     EXPECT_VALID(obj);
     weak1 = Dart_NewWeakPersistentHandle(obj,

[Ivan Posva, 2014/03/27 21:18:16]

Please add comments where you would expect GC, and why as otherwise it is hard
to follow the side-effects.

[koda, 2014/03/27 22:11:13]

Done.

                                          NULL,
                                          kWeak1ExternalSize,
                                          NopCallback);
     EXPECT_VALID(AsHandle(weak1));
-    // While new space is "full" of external data, any allocation will
-    // trigger GC, so after two of them, obj should be promoted.
-    Dart_Handle trigger1 = NewString("trigger1");
-    EXPECT_VALID(trigger1);
-    Dart_Handle trigger2 = NewString("trigger2");
-    EXPECT_VALID(trigger2);
+    // While external size in new space is above limit, any external allocation
+    // in new space will trigger GC, so after one more, obj should be promoted.
+    Dart_WeakPersistentHandle trigger =
+      Dart_NewWeakPersistentHandle(obj, NULL, 1, NopCallback);
+    EXPECT_VALID(AsHandle(trigger));
+    Dart_DeleteWeakPersistentHandle(isolate, trigger);
     {
       DARTSCOPE(Isolate::Current());
       String& handle = String::Handle();
       handle ^= Api::UnwrapHandle(obj);
       EXPECT(handle.IsOld());
     }
     EXPECT(heap->ExternalInWords(Heap::kNew) == 0);
     EXPECT(heap->ExternalInWords(Heap::kOld) == kWeak1ExternalSize / kWordSize);
     Dart_ExitScope();
   }
-  Dart_Isolate isolate = reinterpret_cast<Dart_Isolate>(Isolate::Current());
   Dart_DeleteWeakPersistentHandle(isolate, weak1);
   Isolate::Current()->heap()->CollectGarbage(Heap::kOld);
   EXPECT(heap->ExternalInWords(Heap::kOld) == 0);
 }
 
 
 TEST_CASE(WeakPersistentHandleExternalAllocationSizeOddReferents) {
   Heap* heap = Isolate::Current()->heap();
   Dart_WeakPersistentHandle weak1 = NULL;
   static const intptr_t kWeak1ExternalSize = 1 * KB;
@@ skipping 5734 matching lines @@
                                    NewString("main"),
                                    1,
                                    dart_args);
   int64_t value = 0;
   result = Dart_IntegerToInt64(result, &value);
   EXPECT_VALID(result);
   EXPECT_EQ(6, value);
 }
 
 }  // namespace dart