cc: Adding support for RGBA_4444 tile textures

cc/resources/tile_manager.cc

Index: cc/resources/tile_manager.cc
diff --git a/cc/resources/tile_manager.cc b/cc/resources/tile_manager.cc
index 3d1ce0be9867c876356d931dbf169aaddcef0005..2eafff240a21c718ca7095386a9c096643710a1c 100644
--- a/cc/resources/tile_manager.cc
+++ b/cc/resources/tile_manager.cc
@@ -103,6 +103,14 @@ inline ManagedTileBin BinFromTilePriority(const TilePriority& prio,
 // of time scheduling one enormous set of tasks.
 const size_t kMaxRasterTasks = 256u;
 
+// static
+cc::ResourceProvider::Format GetTextureFormat(
+    cc::ResourceProvider* provider,
+    bool use_rgba_4444_tiles) {
+  return use_rgba_4444_tiles ? cc::ResourceProvider::RGBA_4444 :
+      provider->best_texture_format();

[reveman, 2013/09/13 14:32:49]

should we instead just adjust best_texture_format() when use_rgba_4444_tiles is
used?

[kaanb, 2013/09/13 19:57:39]

I want to make sure we only use 4444 for tile textures. I think enforcing it
here is cleaner.

[reveman, 2013/09/13 20:24:31]

I'm not sure this is the right place though. Maybe it's better to add
ResourceProvider::best_tile_texture_format()?

+}
+
 }  // namespace
 
 RasterTaskCompletionStats::RasterTaskCompletionStats()
@@ -125,7 +133,8 @@ scoped_ptr<TileManager> TileManager::Create(
     size_t num_raster_threads,
     RenderingStatsInstrumentation* rendering_stats_instrumentation,
     bool use_map_image,
-    size_t max_transfer_buffer_usage_bytes) {
+    size_t max_transfer_buffer_usage_bytes,
+    bool use_rgba_4444_tiles) {
   return make_scoped_ptr(
       new TileManager(client,
                       resource_provider,
@@ -135,7 +144,9 @@ scoped_ptr<TileManager> TileManager::Create(
                       PixelBufferRasterWorkerPool::Create(
                           resource_provider,
                           num_raster_threads,
-                          max_transfer_buffer_usage_bytes),
+                          max_transfer_buffer_usage_bytes,
+                          GetTextureFormat(resource_provider,
+                                           use_rgba_4444_tiles)),
                       num_raster_threads,
                       rendering_stats_instrumentation));
 }
@@ -722,6 +733,7 @@ RasterWorkerPool::RasterTask TileManager::CreateRasterTask(Tile* tile) {
       resource_pool_->AcquireResource(
           tile->tile_size_.size(),
           raster_worker_pool_->GetResourceFormat());
+

[reveman, 2013/09/13 14:32:49]

nit: no need to add this blank line.

[kaanb, 2013/09/13 19:57:39]

Done.

   const Resource* const_resource = resource.get();
 
   // Create and queue all image decode tasks that this tile depends on.