Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3802)

Unified Diff: cc/scheduler/texture_uploader.cc

Issue 21159007: cc: Adding support for RGBA_4444 tile textures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: deprecate GLenum format throughout cc Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/scheduler/texture_uploader.cc
diff --git a/cc/scheduler/texture_uploader.cc b/cc/scheduler/texture_uploader.cc
index 920c38e669275d0992d6b5166a1683464aecaad4..d4eedaac13d7116aeccfc6d192cd83253857dff2 100644
--- a/cc/scheduler/texture_uploader.cc
+++ b/cc/scheduler/texture_uploader.cc
@@ -135,7 +135,7 @@ void TextureUploader::Upload(const uint8* image,
gfx::Rect image_rect,
gfx::Rect source_rect,
gfx::Vector2d dest_offset,
- GLenum format,
+ ResourceProvider::TextureFormat format,
gfx::Size size) {
CHECK(image_rect.Contains(source_rect));
@@ -145,10 +145,13 @@ void TextureUploader::Upload(const uint8* image,
BeginQuery();
if (use_map_tex_sub_image_) {
+ LOG(ERROR) << "KAANB: maptex!!!";
UploadWithMapTexSubImage(
image, image_rect, source_rect, dest_offset, format);
} else {
- UploadWithTexSubImage(image, image_rect, source_rect, dest_offset, format);
+ LOG(ERROR) << "KAANB: tex!!!";
+ UploadWithTexSubImage(
+ image, image_rect, source_rect, dest_offset, format);
}
if (is_full_upload)
@@ -174,11 +177,12 @@ void TextureUploader::ReleaseCachedQueries() {
available_queries_.clear();
}
-void TextureUploader::UploadWithTexSubImage(const uint8* image,
- gfx::Rect image_rect,
- gfx::Rect source_rect,
- gfx::Vector2d dest_offset,
- GLenum format) {
+void TextureUploader::UploadWithTexSubImage(
+ const uint8* image,
+ gfx::Rect image_rect,
+ gfx::Rect source_rect,
+ gfx::Vector2d dest_offset,
+ ResourceProvider::TextureFormat format) {
// Instrumentation to debug issue 156107
int source_rect_x = source_rect.x();
int source_rect_y = source_rect.y();
@@ -207,11 +211,10 @@ void TextureUploader::UploadWithTexSubImage(const uint8* image,
gfx::Vector2d offset(source_rect.origin() - image_rect.origin());
const uint8* pixel_source;
- unsigned int bytes_per_pixel = Resource::BytesPerPixel(format);
- // Use 4-byte row alignment (OpenGL default) for upload performance.
- // Assuming that GL_UNPACK_ALIGNMENT has not changed from default.
+ unsigned int bytes_per_pixel = ResourceProvider::BytesPerPixel(format);
+ DCHECK_EQ(0, source_rect.width() % 2);
unsigned int upload_image_stride =
- RoundUp(bytes_per_pixel * source_rect.width(), 4u);
+ RoundUp(bytes_per_pixel * source_rect.width(), bytes_per_pixel);
if (upload_image_stride == image_rect.width() * bytes_per_pixel &&
!offset.x()) {
@@ -239,16 +242,17 @@ void TextureUploader::UploadWithTexSubImage(const uint8* image,
dest_offset.y(),
source_rect.width(),
source_rect.height(),
- format,
- GL_UNSIGNED_BYTE,
+ ResourceProvider::GetGLDataFormat(format),
+ ResourceProvider::GetGLDataType(format),
pixel_source);
}
-void TextureUploader::UploadWithMapTexSubImage(const uint8* image,
- gfx::Rect image_rect,
- gfx::Rect source_rect,
- gfx::Vector2d dest_offset,
- GLenum format) {
+void TextureUploader::UploadWithMapTexSubImage(
+ const uint8* image,
+ gfx::Rect image_rect,
+ gfx::Rect source_rect,
+ gfx::Vector2d dest_offset,
+ ResourceProvider::TextureFormat format) {
// Instrumentation to debug issue 156107
int source_rect_x = source_rect.x();
int source_rect_y = source_rect.y();
@@ -277,13 +281,12 @@ void TextureUploader::UploadWithMapTexSubImage(const uint8* image,
// Offset from image-rect to source-rect.
gfx::Vector2d offset(source_rect.origin() - image_rect.origin());
- unsigned int bytes_per_pixel = Resource::BytesPerPixel(format);
- // Use 4-byte row alignment (OpenGL default) for upload performance.
- // Assuming that GL_UNPACK_ALIGNMENT has not changed from default.
+ unsigned int bytes_per_pixel = ResourceProvider::BytesPerPixel(format);
+ DCHECK_EQ(0, source_rect.width() % 2);
unsigned int upload_image_stride =
- RoundUp(bytes_per_pixel * source_rect.width(), 4u);
+ RoundUp(bytes_per_pixel * source_rect.width(), bytes_per_pixel);
- // Upload tile data via a mapped transfer buffer
+ LOG(ERROR) << "MAPTEX: format: " << format;
uint8* pixel_dest = static_cast<uint8*>(
context_->mapTexSubImage2DCHROMIUM(GL_TEXTURE_2D,
0,
@@ -291,8 +294,10 @@ void TextureUploader::UploadWithMapTexSubImage(const uint8* image,
dest_offset.y(),
source_rect.width(),
source_rect.height(),
- format,
- GL_UNSIGNED_BYTE,
+ ResourceProvider::GetGLDataFormat(
+ format),
+ ResourceProvider::GetGLDataType(
+ format),
GL_WRITE_ONLY));
if (!pixel_dest) {

Powered by Google App Engine
This is Rietveld 408576698