cc: Adding support for RGBA_4444 tile textures

ui/gl/gl_surface_egl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This include must be here so that the includes provided transitively
 // by gl_surface_egl.h don't make it impossible to compile this code.
 #include "third_party/mesa/src/include/GL/osmesa.h"
 
 #include "ui/gl/gl_surface_egl.h"
 
 #if defined(OS_ANDROID)
+#include "base/android/sys_utils.h"
 #include <android/native_window_jni.h>
 #endif
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "build/build_config.h"
 #include "ui/gl/egl_util.h"
 #include "ui/gl/gl_context.h"
@@ skipping 96 matching lines @@
   if (!g_display) {
     LOG(ERROR) << "eglGetDisplay failed with error " << GetLastEGLErrorString();
     return false;
   }
 
   if (!eglInitialize(g_display, NULL, NULL)) {
     LOG(ERROR) << "eglInitialize failed with error " << GetLastEGLErrorString();
     return false;
   }
 
+  bool use_16bit_surface = false;
+#if defined(OS_ANDROID)
+  use_16bit_surface = base::android::SysUtils::IsLowEndDevice();

[no sievers, 2013/08/13 01:13:58]

can you make this static so it's clear that we are not supposed to start using
different configs?

[kaanb, 2013/08/13 04:20:40]

Done.

+#endif
+
   // Choose an EGL configuration.
   // On X this is only used for PBuffer surfaces.
   static const EGLint kConfigAttribs[] = {
     EGL_BUFFER_SIZE, 32,
     EGL_ALPHA_SIZE, 8,
     EGL_BLUE_SIZE, 8,
     EGL_GREEN_SIZE, 8,
     EGL_RED_SIZE, 8,
     EGL_RENDERABLE_TYPE, EGL_OPENGL_ES2_BIT,
     EGL_SURFACE_TYPE, EGL_WINDOW_BIT | EGL_PBUFFER_BIT,
     EGL_NONE
   };
 
+  static const EGLint kConfigAttribs16bit[] = {
+    EGL_BUFFER_SIZE, 16,
+    EGL_RENDERABLE_TYPE, EGL_OPENGL_ES2_BIT,
+    EGL_SURFACE_TYPE, EGL_WINDOW_BIT | EGL_PBUFFER_BIT,

[no sievers, 2013/08/13 01:13:58]

We need to make sure that this config works across devices with pbuffers and
windows for virtual contexts (offscreen contexts might be made current with both
onscreen and offscreen surfaces).

+    EGL_NONE
+  };
+
   EGLint num_configs;
   if (!eglChooseConfig(g_display,
-                       kConfigAttribs,
+                       use_16bit_surface ? kConfigAttribs16bit : kConfigAttribs,
                        NULL,
                        0,
                        &num_configs)) {
     LOG(ERROR) << "eglChooseConfig failed with error "
                << GetLastEGLErrorString();
     return false;
   }
 
   if (num_configs == 0) {
     LOG(ERROR) << "No suitable EGL configs found.";
     return false;
   }
 
   if (!eglChooseConfig(g_display,
-                       kConfigAttribs,
+                       use_16bit_surface ? kConfigAttribs16bit : kConfigAttribs,

[no sievers, 2013/08/13 01:13:58]

It seems like num_configs could be >0 (since it's more vague above). If you are
DCHECKing() for the precise config you want below, why don't you just add it to
kConfigAttribs16bit in the first place then?

[kaanb, 2013/08/13 04:20:40]

The trouble is if you explicitly ask for 5-6-5 you get a 8-8-8 or 8-8-8-8 as
higher resolutions have higher priority. Just asking for 16bits is the only
reliable way of getting 16bits. It is explained here:

http://malideveloper.arm.com/develop-for-mali/sample-code/selecting-the-corre...

                        &g_config,
                        1,
                        &num_configs)) {
     LOG(ERROR) << "eglChooseConfig failed with error "
                << GetLastEGLErrorString();
     return false;

[no sievers, 2013/08/13 01:13:58]

Also, if we don't get a 16bit config, should we fall back to 32bit?

[kaanb, 2013/08/13 04:20:40]

I think the eglChooseConfig will automatically select the 32bit configuration if
it's the only available one. So we don't need a fallback logic.

   }
 
+  if (use_16bit_surface) {
+    EGLint red_size, green_size, blue_size;
+    eglGetConfigAttrib(g_display, g_config, EGL_RED_SIZE, &red_size);
+    eglGetConfigAttrib(g_display, g_config, EGL_GREEN_SIZE, &green_size);
+    eglGetConfigAttrib(g_display, g_config, EGL_BLUE_SIZE, &blue_size);
+
+    DCHECK_EQ(5, red_size);
+    DCHECK_EQ(6, green_size);
+    DCHECK_EQ(5, blue_size);
+  }
+
   g_egl_extensions = eglQueryString(g_display, EGL_EXTENSIONS);
   g_egl_create_context_robustness_supported =
       HasEGLExtension("EGL_EXT_create_context_robustness");
   g_egl_sync_control_supported =
       HasEGLExtension("EGL_CHROMIUM_sync_control");
 
   initialized = true;
 
   return true;
 }
@@ skipping 497 matching lines @@
     }
     default:
       NOTREACHED();
       return NULL;
   }
 }
 
 #endif
 
 }  // namespace gfx