cc/resources/resource_format.h - Issue 21159007: cc: Adding support for RGBA_4444 tile textures

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/resources/resource_format.h

Issue 21159007: cc: Adding support for RGBA_4444 tile textures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review comments Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CC_RESOURCES_RESOURCE_FORMAT_H_

	6 #define CC_RESOURCES_RESOURCE_FORMAT_H_

	7

	8 #include "base/logging.h"

	9 #include "third_party/skia/include/core/SkBitmap.h"

	10

	11 namespace cc {

	12

	13 enum ResourceFormat {

	14 RGBA_8888,

	15 RGBA_4444,

	16 BGRA_8888,

	17 LUMINANCE_8,

	18 RESOURCE_FORMAT_MAX = LUMINANCE_8,
	reveman 2013/09/16 15:55:14 Note: we typically use NUM_RESOURCE_FORMATS in cc/ Note: we typically use NUM_RESOURCE_FORMATS in cc/ code but I prefer this and there seems to be a mix of this and _NUM throughout the chromium code so I think it's OK to keep this as is. I'm hoping we can switch to something like this in the long term: https://codereview.chromium.org/22911037/ kaanb 2013/09/16 18:36:37 Acknowledged. Show quoted text On 2013/09/16 15:55:14, David Reveman wrote: > Note: we typically use NUM_RESOURCE_FORMATS in cc/ code but I prefer this and > there seems to be a mix of this and _NUM throughout the chromium code so I think > it's OK to keep this as is. I'm hoping we can switch to something like this in > the long term: https://codereview.chromium.org/22911037/ Acknowledged.
	19 };

	20

	21 SkBitmap::Config SkBitmapConfigFromFormat(ResourceFormat format);

	22

	23 } // namespace cc

	24

	25 #endif // CC_RESOURCES_RESOURCE_FORMAT_H_

OLD	NEW