cc/resources/resource_format.h - Issue 21159007: cc: Adding support for RGBA_4444 tile textures

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/resources/resource_format.h

Issue 21159007: cc: Adding support for RGBA_4444 tile textures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review feedback Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "cc/output/software_frame_data.h"	5 #ifndef CC_RESOURCES_RESOURCE_FORMAT_H_

	6 #define CC_RESOURCES_RESOURCE_FORMAT_H_

6	7

7 namespace cc {	8 namespace cc {

8	9

9 SoftwareFrameData::SoftwareFrameData()	10 enum ResourceFormat {

10 : id(0),	11 RGBA_8888,

11 handle(base::SharedMemory::NULLHandle()) {}	12 RGBA_4444,

12	13 BGRA_8888,

13 SoftwareFrameData::~SoftwareFrameData() {}	14 LUMINANCE_8,
	piman 2013/09/14 00:14:17 nit: can you add RESOURCE_FORMAT_MAX = LUMINANCE_8 nit: can you add RESOURCE_FORMAT_MAX = LUMINANCE_8, and use RESOURCE_FORMAT_MAX in cc_messages.h? I don't want someone adding a value here and forgetting to update cc_messages.h, which would cause some values to fail with the delegated renderer. kaanb 2013/09/14 00:36:25 Done. Show quoted text On 2013/09/14 00:14:17, piman wrote: > nit: can you add RESOURCE_FORMAT_MAX = LUMINANCE_8, and use RESOURCE_FORMAT_MAX > in cc_messages.h? I don't want someone adding a value here and forgetting to > update cc_messages.h, which would cause some values to fail with the delegated > renderer. Done.
	15 };

14	16

15 } // namespace cc	17 } // namespace cc

	18

	19 #endif // CC_RESOURCES_RESOURCE_FORMAT_H_

OLD	NEW

« cc/resources/raster_worker_pool.cc ('K') | « cc/resources/resource.cc ('k') | cc/resources/resource_pool.h » ('j') | cc/resources/tile_manager.cc » ('J')