cc: Adding support for RGBA_4444 tile textures

cc/resources/resource.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_RESOURCES_RESOURCE_H_
 #define CC_RESOURCES_RESOURCE_H_
 
 #include "cc/base/cc_export.h"
 #include "cc/resources/resource_provider.h"
 #include "third_party/khronos/GLES2/gl2.h"
 #include "ui/gfx/size.h"
 
 namespace cc {
 
 class CC_EXPORT Resource {
  public:
   Resource() : id_(0) {}
-  Resource(unsigned id, gfx::Size size, GLenum format)
+  Resource(unsigned id,
+           gfx::Size size,
+           GLenum format,
+           ResourceProvider::TextureType type)
       : id_(id),
         size_(size),
-        format_(format) {}
+        format_(format),

[epennerAtGoogle, 2013/09/11 19:21:04]

In what case can format vary independently from Type?

Can't we just remove it from the constructor and set the format based on type?

[kaanb, 2013/09/12 07:53:44]

Done.

+        type_(type) {}
 
   ResourceProvider::ResourceId id() const { return id_; }
   gfx::Size size() const { return size_; }
   GLenum format() const { return format_; }
 
   size_t bytes() const;
 
-  static size_t BytesPerPixel(GLenum format);
-  static size_t MemorySizeBytes(gfx::Size size, GLenum format);
+  static size_t MemorySizeBytes(
+      gfx::Size size, GLenum format, ResourceProvider::TextureType type);
 
  protected:
   void set_id(ResourceProvider::ResourceId id) { id_ = id; }
   void set_dimensions(gfx::Size size, GLenum format) {
     size_ = size;
     format_ = format;
   }
 
  private:
   ResourceProvider::ResourceId id_;
   gfx::Size size_;
   GLenum format_;
+  ResourceProvider::TextureType type_;
 
   DISALLOW_COPY_AND_ASSIGN(Resource);
 };
 
 }  // namespace cc
 
 #endif  // CC_RESOURCES_RESOURCE_H_