cc: Adding support for RGBA_4444 tile textures

cc/resources/resource.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/resource.h"
 #include "third_party/khronos/GLES2/gl2ext.h"
 
 namespace cc {
 
 size_t Resource::bytes() const {
   if (size_.IsEmpty())
     return 0;
 
-  return MemorySizeBytes(size_, format_);
+  return MemorySizeBytes(size_, format_, is_16_bit_resource_);

[vangelis, 2013/09/10 01:52:19]

It would be cleaner if this parameter was a bytes_per_component rather than a
boolean is_16_bit_resource (it's not self-explanatory what the
!is_16_bit_resource_ really means). 

[kaanb, 2013/09/11 04:01:52]

I changed it to be the texture type.

 }
 
-size_t Resource::BytesPerPixel(GLenum format) {
+size_t Resource::BytesPerPixel(GLenum format, bool is_16_bit_resource) {
   size_t components_per_pixel = 0;
   size_t bytes_per_component = 1;
   switch (format) {
     case GL_RGBA:
+      components_per_pixel = (is_16_bit_resource) ? 2 : 4;

[vangelis, 2013/09/10 01:52:19]

I think what you want to change here is the bytes_per_component, not the
components_per_pixel.

[kaanb, 2013/09/11 04:01:52]

Yes, moved this method to ResourceProvider and I renamed bytes_per_component to
bits_per_component.

+      break;
     case GL_BGRA_EXT:
       components_per_pixel = 4;
       break;
     case GL_LUMINANCE:
       components_per_pixel = 1;
       break;
     default:
       NOTREACHED();
   }
   return components_per_pixel * bytes_per_component;
 }
 
-size_t Resource::MemorySizeBytes(gfx::Size size, GLenum format) {
-  return BytesPerPixel(format) * size.width() * size.height();
+size_t Resource::MemorySizeBytes(
+    gfx::Size size, GLenum format, bool is_16_bit_resource) {
+  return
+      BytesPerPixel(format, is_16_bit_resource) * size.width() * size.height();
 }
 
 
 }  // namespace cc