Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2115873002:
Site Settings Android: Add UMA for the Autoplay. (Closed)
|
Created:
4 years, 5 months ago by Finnur Modified:
4 years, 5 months ago CC:
asvitkine+watch_chromium.org, chromium-reviews, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSite Settings Android: Add UMA for measuring the Autoplay
default setting value at profile startup.
BUG=622713
Committed: https://crrev.com/bd376092ad7bf6a2764f31eeee556f4b2c77584b
Cr-Commit-Position: refs/heads/master@{#403473}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Move to !ios section #
Messages
Total messages: 23 (13 generated)
finnur@chromium.org changed reviewers: + mlamouri@chromium.org
Mounir, see if this fits the bill. I'll find owners and add them as a next step.
Description was changed from ========== Site Settings Android: Add UMA for the Autoplay. BUG=622713 ========== to ========== Site Settings Android: Add UMA for the Autoplay. BUG=622713 ==========
finnur@chromium.org changed reviewers: + bauerb@chromium.org
lgtm, thanks! :) Can you rewrite the CL description to say that it's actually measuring the autoplay default setting value at startup?
Description was changed from ========== Site Settings Android: Add UMA for the Autoplay. BUG=622713 ========== to ========== Site Settings Android: Add UMA for measuring the Autoplay default setting value at profile startup. BUG=622713 ==========
finnur@chromium.org changed reviewers: + isherman@chromium.org
Description was changed from ========== Site Settings Android: Add UMA for measuring the Autoplay default setting value at profile startup. BUG=622713 ========== to ========== Site Settings Android: Add UMA for measuring the Autoplay default setting value at profile startup. BUG=622713 ==========
msramek@chromium.org changed reviewers: + msramek@chromium.org
https://codereview.chromium.org/2115873002/diff/1/components/content_settings... File components/content_settings/core/browser/content_settings_default_provider.cc (right): https://codereview.chromium.org/2115873002/diff/1/components/content_settings... components/content_settings/core/browser/content_settings_default_provider.cc:119: UMA_HISTOGRAM_ENUMERATION( Drive by! This should go down to the "!defined(OS_IOS)" section, since AUTOPLAY is only defined on Desktop and Android. Ideally at the bottom, to keep the ordering approximately as in ContentSettingsType.
Bernhard and Ilya can you do OWNERS check on: content_settings_default_provider.cc and histograms.xml ... respectively.
https://codereview.chromium.org/2115873002/diff/1/components/content_settings... File components/content_settings/core/browser/content_settings_default_provider.cc (right): https://codereview.chromium.org/2115873002/diff/1/components/content_settings... components/content_settings/core/browser/content_settings_default_provider.cc:119: UMA_HISTOGRAM_ENUMERATION( Good point. Done.
LGTM
LGTM
The CQ bit was checked by finnur@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mlamouri@chromium.org Link to the patchset: https://codereview.chromium.org/2115873002/#ps20001 (title: "Move to !ios section")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Site Settings Android: Add UMA for measuring the Autoplay default setting value at profile startup. BUG=622713 ========== to ========== Site Settings Android: Add UMA for measuring the Autoplay default setting value at profile startup. BUG=622713 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Site Settings Android: Add UMA for measuring the Autoplay default setting value at profile startup. BUG=622713 ========== to ========== Site Settings Android: Add UMA for measuring the Autoplay default setting value at profile startup. BUG=622713 Committed: https://crrev.com/bd376092ad7bf6a2764f31eeee556f4b2c77584b Cr-Commit-Position: refs/heads/master@{#403473} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/bd376092ad7bf6a2764f31eeee556f4b2c77584b Cr-Commit-Position: refs/heads/master@{#403473}
Message was sent while issue was closed.
Patchset #3 (id:40001) has been deleted
Message was sent while issue was closed.
Patchset #3 (id:60001) has been deleted |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
