chrome/browser/resources/settings/site_settings/site_settings_behavior.js - Issue 2115833003: Site Settings Desktop: Implement the cookies list and details dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_settings_behavior.js

Issue 2115833003: Site Settings Desktop: Implement the cookies list and details dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/site_settings/site_data_details_dialog.js ('K') | « chrome/browser/resources/settings/site_settings/site_list.html ('k') | chrome/browser/resources/settings/site_settings/site_settings_category.html » ('j') | chrome/browser/ui/webui/settings/settings_cookies_view_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_settings_behavior.js

diff --git a/chrome/browser/resources/settings/site_settings/site_settings_behavior.js b/chrome/browser/resources/settings/site_settings/site_settings_behavior.js

index a89c24b6e576fb86b30ca84274e5976565b8d9d6..86ee14b310d535a8e6d5c43e6b3f104bf8ce4e29 100644

--- a/chrome/browser/resources/settings/site_settings/site_settings_behavior.js

+++ b/chrome/browser/resources/settings/site_settings/site_settings_behavior.js

@@ -362,12 +362,12 @@ var SiteSettingsBehaviorImpl = {

/**

* Returns the icon to use for a given site.

- * @param {SiteException} site The url of the site to fetch the icon for.

+ * @param {string} site The url of the site to fetch the icon for.

* @return {string} The background-image style with the favicon.

* @private

computeSiteIcon: function(site) {

- var url = this.ensureUrlHasScheme(site.originForDisplay);

+ var url = this.ensureUrlHasScheme(site);

return 'background-image: ' + cr.icon.getFaviconImageSet(url);

};