chrome/browser/resources/settings/site_settings/site_data_details_dialog.html - Issue 2115833003: Site Settings Desktop: Implement the cookies list and details dialog.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/site_settings/site_data_details_dialog.html

Issue 2115833003: Site Settings Desktop: Implement the cookies list and details dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix button style and alignment Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/site_settings/site_data.js ('K') | « chrome/browser/resources/settings/site_settings/site_data.js ('k') | chrome/browser/resources/settings/site_settings/site_data_details_dialog.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/pap er-dropdown-menu.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">

	5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-lis tbox.html">

	6 <link rel="import" href="/i18n_setup.html">

	7 <link rel="import" href="/settings_shared_css.html">

	8

	9 <dom-module id="site-data-details-dialog">

	10 <template>

	11 <style include="settings-shared">

	12 .remove-button {

	13 margin-top: 12px;

	14 }

	15 </style>

	16 <cr-dialog id="dialog">

	17 <div class="title">

	18 [[title_]]

	19 </div>

	20 <div class="body">

	21 <div class="layout horizontal" id="container">

	22 <div class="flex">

	23 <paper-dropdown-menu>
	michaelpg 2016/07/05 18:01:11 should this be disabled or something when there's should this be disabled or something when there's only one item? Finnur 2016/07/06 09:57:35 It's hidden when there's only one item (see popula It's hidden when there's only one item (see populateDialog_).
	24 <paper-listbox id="picker" class="dropdown-content"

	25 attr-for-selected="picker-value"

	26 on-iron-activate="onItemSelected_">

	27 <template is="dom-repeat" items="[[entries_]]">

	28 <paper-item picker-value$="[[item.id]]">

	29 [[item.title]]

	30 </paper-item>

	31 </template>

	32 </paper-listbox>

	33 </paper-dropdown-menu>

	34 </div>

	35 <div class="button-container">

	36 <paper-button on-tap="onRemove_"

	37 class="cancel-button remove-button">
	Finnur 2016/07/05 14:00:18 The latest mocks have this button in the same styl The latest mocks have this button in the same style as the cancel button (not blue) and I took the opportunity and also aligned it better vertically. (post screenshot)
	38 $i18n{siteSettingsCookieRemove}

	39 </paper-button>

	40 </div>

	41 </div>

	42

	43 <div id="content"></div>

	44

	45 <div class="button-container">

	46 <paper-button class="cancel-button" dialog-dismiss>

	47 $i18n{cancel}

	48 </paper-button>

	49 <paper-button class="action-button" dialog-dismiss
	michaelpg 2016/07/05 18:01:11 dialog-confirm? (though I don't think it really ma dialog-confirm? (though I don't think it really matters) Finnur 2016/07/06 09:57:35 Done. Show quoted text On 2016/07/05 18:01:11, michaelpg wrote: > dialog-confirm? (though I don't think it really matters) Done.
	50 id="clear" on-tap="onRemoveAll_">

	51 $i18n{siteSettingsCookieRemoveAll}

	52 </paper-button>

	53 </div>

	54 </div>

	55 </cr-dialog>

	56 </template>

	57 <script src="cookie_tree_node.js"></script>

	58 <script src="site_data_details_dialog.js"></script>

	59 </dom-module>

OLD	NEW