content/browser/devtools/devtools_manager.cc - Issue 2115823004: Avoid using BrowserThread and ContentBrowserClient in NetLogObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_manager.cc

Issue 2115823004: Avoid using BrowserThread and ContentBrowserClient in NetLogObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix leak Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/devtools/devtools_manager.cc

diff --git a/content/browser/devtools/devtools_manager.cc b/content/browser/devtools/devtools_manager.cc

index f3004a3e7e721fa1ddd3cb0083219b31272b5a49..d4889002d9f3f70d038c46c921f289f7647d99d6 100644

--- a/content/browser/devtools/devtools_manager.cc

+++ b/content/browser/devtools/devtools_manager.cc

@@ -34,7 +34,8 @@ void DevToolsManager::AgentHostStateChanged(

BrowserThread::PostTask(

BrowserThread::IO,

FROM_HERE,

- base::Bind(&NetLogObserver::Attach));

+ base::Bind(&NetLogObserver::Attach,

+ GetContentClient()->browser()->GetNetLog()));

}

++attached_hosts_count_;

} else {

« no previous file with comments | « no previous file | content/browser/loader/netlog_observer.h » ('j') | no next file with comments »