Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: content/browser/devtools/devtools_manager.cc

Issue 2115823004: Avoid using BrowserThread and ContentBrowserClient in NetLogObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix build error Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/loader/netlog_observer.h » ('j') | content/browser/loader/netlog_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/devtools_manager.cc
diff --git a/content/browser/devtools/devtools_manager.cc b/content/browser/devtools/devtools_manager.cc
index f3004a3e7e721fa1ddd3cb0083219b31272b5a49..92b3b04031d2a367e85919416322cfe7fc1574f2 100644
--- a/content/browser/devtools/devtools_manager.cc
+++ b/content/browser/devtools/devtools_manager.cc
@@ -21,6 +21,9 @@ DevToolsManager* DevToolsManager::GetInstance() {
DevToolsManager::DevToolsManager()
: delegate_(GetContentClient()->browser()->GetDevToolsManagerDelegate()),
attached_hosts_count_(0) {
+ // Pass the IO thread task runner to the NetLogObserver class.
+ NetLogObserver::SetIOThreadTaskRunner(
pfeldman 2016/07/06 18:36:14 It is unclear why netlog observer is initialized w
ananta 2016/07/08 14:11:02 Passed it via Attach instead.
+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO));
}
DevToolsManager::~DevToolsManager() {
@@ -34,7 +37,8 @@ void DevToolsManager::AgentHostStateChanged(
BrowserThread::PostTask(
BrowserThread::IO,
FROM_HERE,
- base::Bind(&NetLogObserver::Attach));
+ base::Bind(&NetLogObserver::Attach,
+ GetContentClient()->browser()->GetNetLog()));
}
++attached_hosts_count_;
} else {
« no previous file with comments | « no previous file | content/browser/loader/netlog_observer.h » ('j') | content/browser/loader/netlog_observer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698