Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: content/browser/devtools/devtools_manager.cc

Issue 2115823004: Avoid using BrowserThread and ContentBrowserClient in NetLogObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix leak Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/loader/netlog_observer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/devtools/devtools_manager.h" 5 #include "content/browser/devtools/devtools_manager.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "content/browser/devtools/devtools_agent_host_impl.h" 9 #include "content/browser/devtools/devtools_agent_host_impl.h"
10 #include "content/browser/loader/netlog_observer.h" 10 #include "content/browser/loader/netlog_observer.h"
(...skipping 16 matching lines...) Expand all
27 DCHECK(!attached_hosts_count_); 27 DCHECK(!attached_hosts_count_);
28 } 28 }
29 29
30 void DevToolsManager::AgentHostStateChanged( 30 void DevToolsManager::AgentHostStateChanged(
31 DevToolsAgentHostImpl* agent_host, bool attached) { 31 DevToolsAgentHostImpl* agent_host, bool attached) {
32 if (attached) { 32 if (attached) {
33 if (!attached_hosts_count_) { 33 if (!attached_hosts_count_) {
34 BrowserThread::PostTask( 34 BrowserThread::PostTask(
35 BrowserThread::IO, 35 BrowserThread::IO,
36 FROM_HERE, 36 FROM_HERE,
37 base::Bind(&NetLogObserver::Attach)); 37 base::Bind(&NetLogObserver::Attach,
38 GetContentClient()->browser()->GetNetLog()));
38 } 39 }
39 ++attached_hosts_count_; 40 ++attached_hosts_count_;
40 } else { 41 } else {
41 --attached_hosts_count_; 42 --attached_hosts_count_;
42 if (!attached_hosts_count_) { 43 if (!attached_hosts_count_) {
43 BrowserThread::PostTask( 44 BrowserThread::PostTask(
44 BrowserThread::IO, 45 BrowserThread::IO,
45 FROM_HERE, 46 FROM_HERE,
46 base::Bind(&NetLogObserver::Detach)); 47 base::Bind(&NetLogObserver::Detach));
47 } 48 }
48 } 49 }
49 } 50 }
50 51
51 } // namespace content 52 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/browser/loader/netlog_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698