Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(365)

Issue 2115813002: Enable compiling with clang chrome plugins for GYP build (Closed)

Created:
4 years, 3 months ago by Wei Li
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Enable compiling with clang chrome plugins for GYP build For standalone build, enable the compilation with clang_use_chrome_plugins. Also remove the previous clang_use_pdfium_plugins to be consistent with chrome build, also avoid errors on chromeos_ozone build. BUG=pdfium:469 Committed: https://pdfium.googlesource.com/pdfium/+/1d13fb7be58a0909f532e4f4da572e69ecbb2c8e

Patch Set 1 #

Patch Set 2 : fix on mac #

Patch Set 3 : fix on win #

Patch Set 4 : fix on xfa #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -38 lines) Patch
M build_gyp/standalone.gypi View 1 2 5 chunks +53 lines, -0 lines 0 comments Download
M pdfium.gyp View 3 chunks +3 lines, -38 lines 0 comments Download
M xfa.gyp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115813002/80001
4 years, 3 months ago (2016-07-01 18:12:30 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 3 months ago (2016-07-01 18:28:21 UTC) #6
Wei Li
pls review, thanks
4 years, 3 months ago (2016-07-01 18:41:41 UTC) #8
Lei Zhang
lgtm
4 years, 3 months ago (2016-07-01 19:25:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115813002/80001
4 years, 3 months ago (2016-07-01 22:59:33 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:80001) as https://pdfium.googlesource.com/pdfium/+/1d13fb7be58a0909f532e4f4da572e69ecbb2c8e
4 years, 3 months ago (2016-07-01 22:59:53 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-07-01 22:59:56 UTC) #14
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698