Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2115793002: Properly initialize last_notification_severity_. (Closed)

Created:
4 years, 5 months ago by dspaid
Modified:
4 years, 5 months ago
Reviewers:
satorux1
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly initialize last_notification_severity_. BUG=622590 TEST=./out/Debug/unit_tests --gtest_filter=LowDiskNotificationTest.* Committed: https://crrev.com/df142fd2cb934119b9dadc9971cd6b52dd85f249 Cr-Commit-Position: refs/heads/master@{#403420}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/chromeos/ui/low_disk_notification.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
dspaid
Minor fix for uninitialized variable
4 years, 5 months ago (2016-07-01 06:26:39 UTC) #2
satorux1
good catch! lgtm
4 years, 5 months ago (2016-07-01 06:32:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115793002/1
4 years, 5 months ago (2016-07-01 06:33:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 07:15:36 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 07:15:40 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 07:18:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df142fd2cb934119b9dadc9971cd6b52dd85f249
Cr-Commit-Position: refs/heads/master@{#403420}

Powered by Google App Engine
This is Rietveld 408576698