Issue 2115783002: Merge "Improve performance of HTMLSelectElement::setActiveSelectionAnchor()." to M52.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2115783002: Merge "Improve performance of HTMLSelectElement::setActiveSelectionAnchor()." to M52. (Closed)

Created:
4 years, 5 months ago by tkent

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

Merge "Improve performance of HTMLSelectElement::setActiveSelectionAnchor()." to M52. Do not update m_cachedStateForActiveSelection if it's a menulist. m_cachedStateForActiveSelection is used only in listboxes. Removing 20,000 OPTIONs: 4,787ms -> 3,772ms BUG=624220 Review-Url: https://codereview.chromium.org/2104883004 Cr-Commit-Position: refs/heads/master@{#402765} (cherry picked from commit 25445ac85b61754a12be2ccc65ddb1ef5aa96635) Committed: https://chromium.googlesource.com/chromium/src/+/195e6941595c73f8fbcf09d1eb4773e82dd409d8

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	third_party/WebKit/Source/core/html/HTMLSelectElement.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	third_party/WebKit/Source/core/html/HTMLSelectElement.cpp	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

tkent

4 years, 5 months ago (2016-07-01 05:51:51 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
195e6941595c73f8fbcf09d1eb4773e82dd409d8.