Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2115763002: Update //build, //buildtools from chromium. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
bradnelson
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Update //build, //buildtools, clang from chromium. This pulls in the latest GN binaries and config, and also syncs up GYP. We need to update things before we can land a GN fix needed for ChromeOS. R=bradnelson@chromium.org BUG=621686 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/4c2f8b31d6d3aa5f77182f9b0d8f0769332f2663

Patch Set 1 #

Patch Set 2 : revert breakpad change; wrong repo #

Patch Set 3 : roll buildtools, clang also #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M DEPS View 1 2 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
Dirk Pranke
4 years, 5 months ago (2016-07-01 02:12:27 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115763002/1
4 years, 5 months ago (2016-07-01 02:12:44 UTC) #3
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
4 years, 5 months ago (2016-07-01 02:12:45 UTC) #5
bradnelson
lgtm
4 years, 5 months ago (2016-07-01 05:21:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115763002/1
4 years, 5 months ago (2016-07-01 05:21:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: nacl-mac_arm_newlib_opt on master.tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_arm_newlib_opt/builds/405) nacl-mac_glibc_dbg on master.tryserver.nacl (JOB_FAILED, ...
4 years, 5 months ago (2016-07-01 05:22:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115763002/20001
4 years, 5 months ago (2016-07-01 21:01:27 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: nacl-mac_arm_newlib_opt on master.tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac_arm_newlib_opt/builds/406) nacl-mac_glibc_opt on master.tryserver.nacl (JOB_FAILED, ...
4 years, 5 months ago (2016-07-01 21:02:58 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115763002/40001
4 years, 5 months ago (2016-07-01 22:35:52 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-01 23:56:29 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115763002/40001
4 years, 5 months ago (2016-07-02 01:06:50 UTC) #24
commit-bot: I haz the power
4 years, 5 months ago (2016-07-02 01:08:10 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/native_client/src/native_client/+/4c2f8b31d...

Powered by Google App Engine
This is Rietveld 408576698