pkg/analyzer/lib/src/generated/static_type_analyzer.dart - Issue 2115743002: simplify inference of generic function types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/static_type_analyzer.dart

Issue 2115743002: simplify inference of generic function types (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/generated/static_type_analyzer.dart

diff --git a/pkg/analyzer/lib/src/generated/static_type_analyzer.dart b/pkg/analyzer/lib/src/generated/static_type_analyzer.dart

index 5c57bb8f945f9fc4f3e3a3387fd54c159f8f7baa..896b0ab5110a2588e59546998ce9293d3bb668fd 100644

--- a/pkg/analyzer/lib/src/generated/static_type_analyzer.dart

+++ b/pkg/analyzer/lib/src/generated/static_type_analyzer.dart

@@ -1903,7 +1903,7 @@ class StaticTypeAnalyzer extends SimpleAstVisitor<Object> {

FunctionType inferred = ts.inferGenericFunctionCall(_typeProvider, fnType,

paramTypes, argTypes, InferenceContext.getType(node));

- if (inferred != node.staticInvokeType) {

+ if (inferred != null && inferred != node.staticInvokeType) {

// Fix up the parameter elements based on inferred method.

List<ParameterElement> inferredParameters =

ResolverVisitor.resolveArgumentsToParameters(

« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/type_system.dart » ('j') | no next file with comments »