Add Play Store listings text for Chromoting app

Add Play Store listings text for Chromoting app

R=jamiewalch@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259762

[Lambros, 2014-03-26 04:01:29]

Do you have any better ideas for suppressing the "defined but not used"
warnings? :)

[Jamie, 2014-03-26 17:08:26]

A better way to suppress the warnings would be to explicitly tag the Play
strings with a custom attribute in the GRD file, assuming the format allows (and
ignores) unrecognized attributes. If XML supports namespaced attributes, I
suggest something like remoting:external-string=true.

https://codereview.chromium.org/211573008/diff/1/remoting/resources/play_stor...
File remoting/resources/play_store_resources.cc (right):

https://codereview.chromium.org/211573008/diff/1/remoting/resources/play_stor...
remoting/resources/play_store_resources.cc:6: IDS_PLAY_STORE_TITLE
Will this work without /*i18n-content*/ comments?

https://codereview.chromium.org/211573008/diff/1/remoting/resources/remoting_...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/211573008/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:425: <message
name="IDS_PLAY_STORE_TITLE" desc="Play Store title of the Chrome Remote Desktop
app for Android. [CHAR-LIMIT=30] [NAME=play_store_title]">
I don't understand the need for [NAME=...] in these resources. Why do the
translators need to know the name of the resource?

https://codereview.chromium.org/211573008/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:429: Securely access your computers from
your Android phone or tablet.
Maybe s/phone or tablet/device/ here and below?

https://codereview.chromium.org/211573008/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:434: • From each of your computers, set
up remote access using our app on the Chrome Web Store:
https://chrome.google.com/remotedesktop
I think we should avoid using "our". Maybe "the Chrome Remote Desktop app on
Chrome Web Store: <url>"?

https://codereview.chromium.org/211573008/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:435: • From your Android device, open
the app to see which of your computers are available to connect.
s/connect/connect to/

Although this list seems more verbose than it needs to be. Why not combine the
last two items into "From your Android device, open the app and tap on the
computer you want to connect to."

[Lambros, 2014-03-26 21:34:19]

I looked into adding extra XML attributes to the .grd files, but GRIT won't
allow it :(

https://codereview.chromium.org/211573008/diff/1/remoting/resources/play_stor...
File remoting/resources/play_store_resources.cc (right):

https://codereview.chromium.org/211573008/diff/1/remoting/resources/play_stor...
remoting/resources/play_store_resources.cc:6: IDS_PLAY_STORE_TITLE
On 2014/03/26 17:08:26, Jamie wrote:
> Will this work without /*i18n-content*/ comments?
Yes, that's the reason I chose .cc over other formats.

https://codereview.chromium.org/211573008/diff/1/remoting/resources/remoting_...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/211573008/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:425: <message
name="IDS_PLAY_STORE_TITLE" desc="Play Store title of the Chrome Remote Desktop
app for Android. [CHAR-LIMIT=30] [NAME=play_store_title]">
On 2014/03/26 17:08:26, Jamie wrote:
> I don't understand the need for [NAME=...] in these resources. Why do the
> translators need to know the name of the resource?

They're for our benefit, the translators ignore the NAME= annotations but they
find their way into the .xtb files. It will help us when writing a script to
process these. The same technique is used for the Chrome Play Store strings, so
it should work for us as well.

https://codereview.chromium.org/211573008/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:429: Securely access your computers from
your Android phone or tablet.
On 2014/03/26 17:08:26, Jamie wrote:
> Maybe s/phone or tablet/device/ here and below?

Done.

https://codereview.chromium.org/211573008/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:434: • From each of your computers, set
up remote access using our app on the Chrome Web Store:
https://chrome.google.com/remotedesktop
On 2014/03/26 17:08:26, Jamie wrote:
> I think we should avoid using "our". Maybe "the Chrome Remote Desktop app on
> Chrome Web Store: <url>"?

Done.

https://codereview.chromium.org/211573008/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:435: • From your Android device, open
the app to see which of your computers are available to connect.
On 2014/03/26 17:08:26, Jamie wrote:
> s/connect/connect to/
> 
> Although this list seems more verbose than it needs to be. Why not combine the
> last two items into "From your Android device, open the app and tap on the
> computer you want to connect to."

I assume this is addressed by updated strings.

[Jamie, 2014-03-26 21:45:31]

LGTM with one string change.

https://codereview.chromium.org/211573008/diff/60001/remoting/resources/remot...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/211573008/diff/60001/remoting/resources/remot...
remoting/resources/remoting_strings.grd:435: Securely access your computers from
your Android phone or tablet.
s/phone or tablet/device/

[Lambros, 2014-03-26 22:37:10]

https://codereview.chromium.org/211573008/diff/60001/remoting/resources/remot...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/211573008/diff/60001/remoting/resources/remot...
remoting/resources/remoting_strings.grd:435: Securely access your computers from
your Android phone or tablet.
On 2014/03/26 21:45:31, Jamie wrote:
> s/phone or tablet/device/

Done.

[Lambros, 2014-03-26 22:37:13]

The CQ bit was checked by lambroslambrou@chromium.org

[commit-bot: I haz the power, 2014-03-26 22:37:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/211573008/...

[commit-bot: I haz the power, 2014-03-27 00:36:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 00:36:47]

Retried try job too often on win_x64_rel for step(s) base_unittests,
chrome_elf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...

[Lambros, 2014-03-27 01:15:56]

Committed patchset #4 manually as r259762 (presubmit successful).