Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issue 2115723002: [chromedriver] Filter network emulation tests from running on Android. (Closed)

Created:
4 years, 5 months ago by roisinmcl
Modified:
4 years, 5 months ago
Reviewers:
samuong, prasadv
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Filter network emulation tests from running on Android. Network emulation is a desktop-only feature, so Android testing needs to be disabled. BUG=chromedriver:984 Committed: https://crrev.com/cddabc920550a5410ef1781df9111cbda8925964 Cr-Commit-Position: refs/heads/master@{#403391}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/test/chromedriver/test/run_py_tests.py View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
roisinmcl
4 years, 5 months ago (2016-07-01 00:24:19 UTC) #2
samuong
lgtm
4 years, 5 months ago (2016-07-01 01:35:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115723002/1
4 years, 5 months ago (2016-07-01 01:36:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 02:15:44 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 02:17:51 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cddabc920550a5410ef1781df9111cbda8925964
Cr-Commit-Position: refs/heads/master@{#403391}

Powered by Google App Engine
This is Rietveld 408576698