Issue 2115713002: Reduce (debug-only) VerifyMaps from O(n^2) to O(n).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2115713002: Reduce (debug-only) VerifyMaps from O(n^2) to O(n). (Closed)

Created:
4 years, 5 months ago by rmacnak

Modified:
4 years, 5 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Reduce (debug-only) VerifyMaps from O(n^2) to O(n). VerifyMaps in dart2js identity reload 1400-1900ms -> 80-100ms. BUG=http://dartbug.com/26807 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/4e2bcf110b8c904ea36a137e4dc294e053c468d6

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -21 lines)			Patch
	M	runtime/vm/isolate_reload.cc	View	1	5 chunks	+17 lines, -21 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

4 years, 5 months ago (2016-07-01 19:38:56 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
4e2bcf110b8c904ea36a137e4dc294e053c468d6 (presubmit successful).