Issue 21157003: Adds links to dashboard plots for skp bench values out of range. (SkipBuildbotRuns).

Issue 21157003: Adds links to dashboard plots for skp bench values out of range. (SkipBuildbotRuns). (Closed)

Created:
7 years, 4 months ago by benchen

Modified:
7 years, 4 months ago

Reviewers:
borenet

CC:
skia-review_googlegroups.com, skiabot_google.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Adds links to dashboard plots for skp bench values out of range. (SkipBuildbotRuns). They are single-line plots for the specific bench/platform/config combos. Committed: https://code.google.com/p/skia/source/detail?r=10437

Patch Set 1 #

Total comments: 3

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -5 lines)			Patch
	M	bench/bench_graph_svg.py	View		2 chunks	+23 lines, -5 lines	3 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

borenet

LGTM with question. https://codereview.chromium.org/21157003/diff/1/bench/bench_graph_svg.py File bench/bench_graph_svg.py (right): https://codereview.chromium.org/21157003/diff/1/bench/bench_graph_svg.py#newcode407 bench/bench_graph_svg.py:407: link += 'target="_blank">graph</a>' Do we need ...

7 years, 4 months ago (2013-07-30 13:00:33 UTC) #2

benchen

https://codereview.chromium.org/21157003/diff/1/bench/bench_graph_svg.py File bench/bench_graph_svg.py (right): https://codereview.chromium.org/21157003/diff/1/bench/bench_graph_svg.py#newcode407 bench/bench_graph_svg.py:407: link += 'target="_blank">graph</a>' Thanks Eric. I tried to open ...

7 years, 4 months ago (2013-07-30 14:34:33 UTC) #3

benchen

Committed patchset #1 manually as r10437 (presubmit successful).

7 years, 4 months ago (2013-07-30 14:47:07 UTC) #4

borenet

7 years, 4 months ago (2013-07-30 14:47:45 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/21157003/diff/1/bench/bench_graph_svg.py
File bench/bench_graph_svg.py (right):

https://codereview.chromium.org/21157003/diff/1/bench/bench_graph_svg.py#newc...
bench/bench_graph_svg.py:407: link += 'target="_blank">graph</a>'
On 2013/07/30 14:34:34, benchen wrote:
> Thanks Eric. I tried to open a bench logs file with Chrome (no extension name)
> and it showed plain text. Then I added an <a> tag to the file and re-opened
it,
> then Chrome rendered the tag.
> When opening the logs from the bots, there's a "view as text" link at the very
> top - the logs already have <html> tags.
>
http://108.170.217.252:10117/builders/Perf-Ubuntu12-ShuttleA-ATI5770-x86-Rele...
> Assuming people view logs in this mode a lot, I tend to leave the tags in.
> On 2013/07/30 13:00:33, borenet wrote:
> > Do we need HTML here?  AFAIK the output of this script will either be viewed
> in
> > a terminal or in the logs on the buildbots, neither of which will render
HTML.
> 

SGTM

Expand Messages | Collapse Messages