Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: docs/ASAN.rst

Issue 2115693002: Implemented loose checking for potential widened loads (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Added test to commit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/szrt_asan.c » ('j') | tests_lit/asan_tests/wideloads.ll » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/ASAN.rst
diff --git a/docs/ASAN.rst b/docs/ASAN.rst
index 5526c59b2458b6134c762c58f3a4b46722270e00..d815817c042656f9f56fb4df35bb1a1629ea4872 100644
--- a/docs/ASAN.rst
+++ b/docs/ASAN.rst
@@ -27,3 +27,12 @@ AddressSanitizer and properly linked into a final executable using
subzero/pydir/szbuild.py with the --fsanitize-address flag, i.e.::
pydir/szbuild.py --fsanitize-address hello.pexe
+
+Handling Wide Loads
+===================
+
+Since AddressSanitizer is implemented only in Subzero, the target .pexe may
+contain widened loads that would cause false positives. To avoid reporting such
+loads as errors, we treat any word-aligned, four byte load as a potentially
+widened load and only check the first byte of the loaded word against shadow
+memory.
« no previous file with comments | « no previous file | runtime/szrt_asan.c » ('j') | tests_lit/asan_tests/wideloads.ll » ('J')

Powered by Google App Engine
This is Rietveld 408576698