Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2115693002: Implemented loose checking for potential widened loads (Closed)

Created:
4 years, 5 months ago by tlively
Modified:
4 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implemented loose checking for potential widened loads BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374 R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=cf06279931ba91b98fbbd7689353cb6068817497

Patch Set 1 #

Patch Set 2 : changed a line #

Patch Set 3 : Fixed off by one error in checking and added tests #

Patch Set 4 : Added test to commit #

Total comments: 2

Patch Set 5 : Added FileCheck for wide load test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -58 lines) Patch
M docs/ASAN.rst View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/szrt_asan.c View 1 2 3 chunks +41 lines, -15 lines 0 comments Download
M src/IceASanInstrumentation.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/IceASanInstrumentation.cpp View 1 chunk +9 lines, -6 lines 0 comments Download
M tests_lit/asan_tests/errors.ll View 1 2 3 chunks +11 lines, -11 lines 0 comments Download
M tests_lit/asan_tests/instrumentload.ll View 1 2 1 chunk +15 lines, -15 lines 0 comments Download
M tests_lit/asan_tests/instrumentstore.ll View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
A tests_lit/asan_tests/wideloads.ll View 1 2 3 4 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
tlively
4 years, 5 months ago (2016-06-30 22:14:39 UTC) #2
Karl
Looks good, but it should have some test cases.
4 years, 5 months ago (2016-06-30 22:39:51 UTC) #3
tlively
4 years, 5 months ago (2016-07-01 00:37:01 UTC) #4
Karl
Still don't see tests on load widening tests.
4 years, 5 months ago (2016-07-01 15:02:19 UTC) #5
tlively
On 2016/07/01 15:02:19, Karl wrote: > Still don't see tests on load widening tests. My ...
4 years, 5 months ago (2016-07-01 16:45:47 UTC) #6
Karl
https://codereview.chromium.org/2115693002/diff/60001/tests_lit/asan_tests/wideloads.ll File tests_lit/asan_tests/wideloads.ll (right): https://codereview.chromium.org/2115693002/diff/60001/tests_lit/asan_tests/wideloads.ll#newcode8 tests_lit/asan_tests/wideloads.ll:8: ; RUN: %t.pexe -o %t && %t Run this ...
4 years, 5 months ago (2016-07-01 21:16:19 UTC) #7
tlively
https://codereview.chromium.org/2115693002/diff/60001/tests_lit/asan_tests/wideloads.ll File tests_lit/asan_tests/wideloads.ll (right): https://codereview.chromium.org/2115693002/diff/60001/tests_lit/asan_tests/wideloads.ll#newcode8 tests_lit/asan_tests/wideloads.ll:8: ; RUN: %t.pexe -o %t && %t On 2016/07/01 ...
4 years, 5 months ago (2016-07-02 00:34:07 UTC) #8
Karl
lgtm
4 years, 5 months ago (2016-07-02 21:07:42 UTC) #9
tlively
4 years, 5 months ago (2016-07-06 17:02:50 UTC) #11
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
cf06279931ba91b98fbbd7689353cb6068817497 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698